Repository navigation
Windows: show installer failure stages and native errors for Agent 0.0.15 - #1371
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows setup currently hides the failing native check behind a generic “could not be completed safely” message. The existing error dialog now includes the failure stage, full Windows/WinTrust error code, and short guidance for known failures. This also prepares the requested Agent 0.0.15 update.
Preflight/preparation retain full native error bits and fixed nonzero validation categories. The standalone historical-signature probe supplies the same error types to the shared verifier as the normal library build. Existing bootstrap arguments, activation status encoding, rollback, ACL, signature, publisher and timestamp checks remain unchanged. Existing real install/reinstall, launch/icon and uninstall smokes are unchanged. Version edits affect only the Agent workspace and its eight local lockfile entries; external dependencies are unchanged.
Refs #1369. The customer's Windows 10 failure remains undiagnosed. This improves the next report; it does not establish that the customer can install successfully or qualify Windows 10.
Validation:
761a23f1: 40938570851 passed build/package and all existing installation smokes. Later revisions add master’s Settings/update UI change, strengthen one contract assertion, and fix the shared verifier’s standalone example import context; the installer logic is unchanged. The rebased PR head has its own required native compilation/updater checks. Unsigned evidence is not signed release evidence.just ciwas stopped during dependency rebuilding to keep this improvement bounded; local commit hooks were skipped for the handoff. These are not claimed as passed. Required PR CI 40940152589 passed on final head525d4c83: all seven selected lanes andci-ok, including 100 native Windows updater library tests and 5 integration tests with zero failed or ignored. No manual CI dispatch will be made on the open PR branch.No publication, infrastructure, signing-environment, credential, root-certificate or security-policy changes. Release publication follows an approved merge and the normal signed-artifact checks and approvals.