Repository navigation
Fix Windows release preflight for versioned installations - #1320
Merged
Merged
Conversation
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new Windows bootstrap correctly refuses ordinary startup before installation. The release builder nevertheless ran the unsigned, uninstalled executable with
--build-info, so both master Dev and Prod builds failed after successful compilation and before signing (run 40463584325).Use the existing bounded PE metadata reader for Windows build preflight, validating the requested profile and exact full source commit without executing the artifact. Mac/Linux keep their existing runtime CLI checks. Installed Windows startup admission and later signed installer/CLI smoke remain unchanged.
Validation:
build-release.shruns against a non-executable PE fixture for MINGW/MSYS/CYGWIN and both profiles; rejects wrong profiles, source commits and dirty revisions; verifies Mac/Linux CLI execution and mismatched-profile refusal.nix flake check --no-update-lock-filepassed on aarch64-darwin, including release metadata and workflow checks.Both original master failures are preserved. These portable checks do not establish a new native Windows build, signature, installation or updater qualification; those require the next actual master producer. Separate PR/source CI waiting remains waived for the release handoff.
Need help on this PR? Tag
@codesmith-botwith what you need.