Repository navigation
Fix feedback form typing with application Vim - #1319
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With application Vim enabled, the feedback field dropped ordinary typing because it lacked the ordinary-form Vim context and Chat intercepted its key events. Feedback now uses the same input context and Escape handoff as the project-folder form, and the modal exits Chat's composer-typing fallback before application navigation can consume characters. Open forms also follow changes to the Vim setting.
The regression uses real GPUI keystrokes, including literal
i,j,k, andl, while composer Vim is enabled. It failed on the original code with an empty field and passes with the fix. It also checks ordinary editing, multiline text, Tab containment, Escape, live Vim setting changes, and preservation of the chat draft. Agent guidance now records this standard ordinary-form pattern and the need to test actual keystrokes.Native validation: an isolated, ad-hoc-signed macOS build with both application and composer Vim enabled accepted physical
i/j/k/lkeys as text, standard editing, Shift+Enter, Tab cycling, and Escape. No feedback submission was sent during this check.Validation: the full Agent pre-commit suite (
MAPLE_HOOK_FULL=1, running pinnedjust ci) passed: formatting, metadata tests, lint across feature sets, workspace tests, desktop tests, and headless tests. The focused regression was verified failing before the fix and passing afterward.Need help on this PR? Tag
@codesmith-botwith what you need.