Skip to content

Fix feedback form typing with application Vim - #1319

Merged
AnthonyRonning merged 1 commit into
masterfrom
codex-feedback-vim
Oct 27, 2026
Merged

AnthonyRonning merged 1 commit into
masterfrom
codex-feedback-vim

Conversation

@AnthonyRonning

@AnthonyRonning AnthonyRonning commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

With application Vim enabled, the feedback field dropped ordinary typing because it lacked the ordinary-form Vim context and Chat intercepted its key events. Feedback now uses the same input context and Escape handoff as the project-folder form, and the modal exits Chat's composer-typing fallback before application navigation can consume characters. Open forms also follow changes to the Vim setting.

The regression uses real GPUI keystrokes, including literal i, j, k, and l, while composer Vim is enabled. It failed on the original code with an empty field and passes with the fix. It also checks ordinary editing, multiline text, Tab containment, Escape, live Vim setting changes, and preservation of the chat draft. Agent guidance now records this standard ordinary-form pattern and the need to test actual keystrokes.

Native validation: an isolated, ad-hoc-signed macOS build with both application and composer Vim enabled accepted physical i/j/k/l keys as text, standard editing, Shift+Enter, Tab cycling, and Escape. No feedback submission was sent during this check.

Validation: the full Agent pre-commit suite (MAPLE_HOOK_FULL=1, running pinned just ci) passed: formatting, metadata tests, lint across feature sets, workspace tests, desktop tests, and headless tests. The focused regression was verified failing before the fix and passing afterward.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@AnthonyRonning
AnthonyRonning merged commit 291134e into master Oct 27, 2026
33 of 34 checks passed
@AnthonyRonning
AnthonyRonning deleted the codex-feedback-vim branch October 27, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant