Repository navigation
Fix Agent 0.0.9 remote updates and status refresh - #1307
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairing could permit ordinary remote access while every remote update failed: the controller discarded its confirmed outgoing pairing grant, then sent zero or the opposite direction's grant. “Refresh update status” also only reread the remote desktop's cached status. This prepares Agent 0.0.9 with durable directional grants, authenticated recovery of existing 0.0.8 pairings, and an explicit remote signed-feed check.
Known refusals now stay distinct from lost acknowledgements. Uncertain requests retain their operation ID through disconnects and re-pairing and are never automatically resent. Account, revocation, password-store, exact-candidate and installer guards remain enforced; the refresh capability is optional management 7.1 on wire 7. Previous tests checked pairing and installation separately using supplied authority; the new composed regression consumes the actual pairing-produced records without overwriting them.
Validation:
nix develop --no-update-lock-file -c just cipassed: format, nine metadata checks, all four strict Clippy feature configurations, warning-denied workspace build, workspace tests (including 767 runtime and 1,050 desktop tests), and 320 headless tests. The normal pre-commit hook also passed; commit is signed.Native rehearsals use isolated Local accounts, the existing public test signer, loopback feeds and explicit private fixture adapters. macOS retains strict native signature/runtime validation under an ad-hoc fixture identity; these tests do not establish production Developer ID/notarization or public release qualification. Fixture adapters, credentials and machine-specific harnesses are not part of this PR. Published 0.0.8 is unchanged.
The published 0.0.7 wire-6 → wire-7 break is preserved: an already-upgraded controller cannot bootstrap an old wire-6 peer. Those peers still need a direct local update. This PR repairs compatible 0.0.8 pairings and future wire-7 upgrades without a protocol downgrade or cross-major bridge.
Need help on this PR? Tag
@codesmith-botwith what you need.