Repository navigation
fix(agent): detect Linux system theme through isolated helper - #1306
Merged
Merged
Conversation
AnthonyRonning
approved these changes
Oct 26, 2026
AnthonyRonning
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the Linux theme helper isolation and lifecycle, theme override precedence, and macOS compatibility. No actionable findings; applicable hosted CI passed for this revision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/proc/<pid>/root.--internal-theme-watchmode. Keep the GUI's original hardening order; disable core dumps in the helper without making the GUI debugger-accessible.Validation
nix develop --no-update-lock-file -c cargo test --locked -p maple-agent-app --test system_theme_helper -- --include-ignored— 3 passed. Verifies initial theme output, portal-compatible process visibility, disabled core dumps, parent-pipe shutdown, CLI isolation, and no application-state writes.Need help on this PR? Tag
@codesmith-botwith what you need.