Repository navigation
ci(agent): package and sign Windows Dev and Prod installers - #1296
Merged
Merged
Conversation
Contributor
|
Maple Auth development preview: https://998ed0b6.maple-auth-dev.pages.dev Commit: Uses development services. Cloudflare Access applies. Provider OAuth is not configured for PR URLs; use the stable Auth Dev host for OAuth rehearsal. |
Contributor
|
Maple development preview: https://51ad89b7.maple-ca8.pages.dev Commit: Uses development API, billing, flags and PCR configuration. Cloudflare Access applies. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Agent desktop workflow now produces unsigned Windows Dev installer previews on PRs and signed Windows Dev/Prod installers from trusted master. It reuses the existing
windows-signingenvironment, Azure identity/account/profile, and shared Artifact Signing helpers. No Azure configuration changes are needed.Credential-free builders compile x64 MSVC releases with a static CRT and target-specific notices, using the existing validated master dependency archives. Fresh signing workers inspect embedded PE profile/source metadata without running the application, sign the app, NSIS uninstaller and installer, then attest the final files. Separate native verifiers check exact payload/provenance and installed CLI/ACP startup, first GUI render, host shutdown, and state-preserving uninstall. Dev/Prod installation and registration identities are distinct. The installer requires Windows 10 version 1703 (build 15063) or newer for GPUI’s OS ICU dependency.
The Windows host also handles launchers whose job objects deny breakaway: it retries inside the enclosing job only for Windows error 5, retaining that job’s limits and lifetime. An early native test exercises the actual helper under a restrictive job before the full build.
Master package selection requires all six macOS/Linux/Windows Dev/Prod download verifiers. Windows upgrades use manual Actions installers. Computer-use stays in #1295; Agent update feeds, publisher, and Research packaging are unchanged.
Download the unsigned Windows Dev preview.
Validation
just cialso passed earlier in the implementation.a1fb120df.--no-build; full local flake execution failed two unchanged macOS GUI probe fixtures at their two-second startup deadlines. Hosted full flake checks passed above; those local deadlines were not changed.