Repository navigation
fix(sdk): remediate crypto-bigint timing advisory - #1251
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Agent dependency audit and SQLCipher source-verification gate fail on RUSTSEC-2026-0387: the in-tree SDK's P-256 dependency resolves vulnerable
crypto-bigint 0.5.5.Upgrade the Rust SDK to P-256 0.14 and require
crypto-bigint >=0.7.6explicitly, so downstream SDK builds cannot resolve an affected version without this repository's lockfile. Prepare SDK 4.1.2 and update the SDK, Proxy, Agent and Research lockfiles. Keep X25519 on its existing OS-RNG implementation and adapt P-256 key generation/SEC1 calls to the maintained API.Three frozen compatibility tests were first passed against P-256 0.13.2, then passed unchanged after the upgrade. The independent Node-generated vector checks persisted PKCS#8/SPKI identity, existing encrypted-push preview decryption, and tampered authentication-tag rejection. They run in the ordinary SDK library-test gate.
Validation:
just cipassed, including the complete lint feature matrix, workspace tests and headless tests.cargo package --lockedpassed; the packaged manifest/lockfile retain the patched integer floor and include the compatibility fixture.The backend has a separate pre-existing affected graph through its independently pinned Tinfoil/HPKE/SEV dependencies; it is outside this client remediation and requires a separate dependency migration. Registry publication for external SDK users remains a separate action.
Need help on this PR? Tag
@codesmith-botwith what you need.