Repository navigation
fix(agent): use catalog metadata for model selector labels - #1221
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Agent model selector currently displays raw IDs such as
deepseek-v4-1-flash. Use metadata from the advanced/v1/models/catalogAPI for friendly labels in the composer button and dropdown, following Research's precedence: concrete models useshort_name, thendisplay_name; aliases useshort_name, thenlabel. Missing metadata falls back to the original ID.The Rust SDK now retains these optional catalog fields. The app loads presentation metadata once alongside the existing model list, independently so a slow or unavailable catalog does not delay selection. Catalog presentation is fetched through the local controller when viewing a remote computer. Labels do not change saved IDs, task locking, defaults, available models, or auto-model routing.
Validation:
just ci: passed (format, all four Clippy configurations, warning-denied builds, workspace and headless tests). Runtime: 684 passed / 5 ignored; desktop: 816 passed / 2 ignored; headless: 224 passed / 2 ignored.git diff --check: passed.agent-label-smokeate52e9c58b2198a65fc2fb2874c4e701da9b907fe, using linked Local OpenSecret/billing and the Local Pro fixture. Verified catalog labels in the composer and dropdown, DeepSeek selection/checkmark, layout, and persistence after quitting/relaunching. Models without catalog display metadata retain their IDs (observed for Safeguard and Voxtral). No inference or hosted-service validation performed.The commit hook was skipped after both complete component gates passed, avoiding a repeat of their checks.