fix(helm): align values with ts-server-boilerplate server/telemetry split - #106
Open
CL-SHLOMIKONCHA wants to merge 5 commits into
Open
CL-SHLOMIKONCHA wants to merge 5 commits into
CL-SHLOMIKONCHA wants to merge 5 commits into
Conversation
Align the chart with ts-server-boilerplate: - replace the server and telemetry keys of the flat env block with a server scope (port, targetPort, protocol, requestPayloadLimit, responseCompressionEnabled) and a telemetry scope (logger, tracing); the worker keys (httpRetry, jobManagement, disableHttpClientLogs) stay under env - rename logger keys to level and prettyPrint to match the config schema - export the otlp logger url as OTLP_LOGGER_ENDPOINT_URL and resource attributes as OTEL_RESOURCE_ATTRIBUTES in key=value,key=value format, the names the commonBoilerplateV3 schema and the OpenTelemetry SDK read - move global overrides under global.telemetry; only the tracing and otlp logger urls are overridable from global and take precedence over chart values, enabled flags stay chart-level - remove the metrics values and helpers, nothing rendered them; the pod prometheus annotations come from mclabels - drop the merged tracing/metrics/openTelemetryOptions helpers Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Resolves the raster-ingestion umbrella TODO; the export umbrella keeps overriding it to export. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Map opentelemetryOptions.url from OTLP_LOGGER_ENDPOINT_URL and resourceAttributes from OTEL_RESOURCE_ATTRIBUTES, the names the helm configmap now exports. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Matches the value the raster-ingestion umbrella already sets. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
almog8k
approved these changes
Sep 14, 2026
Aligns with ts-server-boilerplate#477: loggerConfig already carries prettyPrint, so spreading it is enough. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: MAPCO-11633, MapColonies/ts-server-boilerplate#476 (MAPCO-11622), raster-export / raster-ingestion umbrella TODOs (
helm-charts-new→charts/raster-export/values.yaml,charts/raster-ingestion/values.yaml). Supersedes the helm parts of #87.Further information:
Default values
mclabels.partOfcoreingestion(raster-ingestion TODO; raster-export keeps overriding toexport)configManagement.offlineModetruetrue(already default, umbrella TODO override can be dropped)jobDefinitions.tasks.validation.reportsDownloadPath/downloads/validation-reports/validation-reports(matches the raster-ingestion override, which can be dropped)telemetry.logger.opentelemetryOptions.enabledfalsetruetelemetry.tracing.enabledfalsetrueServer / telemetry split (mirrors ts-server-boilerplate#476)
envblock:serverscope (port,targetPort,protocol,requestPayloadLimit,responseCompressionEnabled) andtelemetryscope (logger,tracing). The worker keysenv.httpRetry,env.jobManagementandenv.disableHttpClientLogsstay underenvunchanged.level/prettyPrint;logger.opentelemetryOptionsholdsenabled,urland optionalresourceAttributes.OTLP_LOGGER_ENDPOINT_URL, the name thecommonBoilerplateV3schema reads; the previousOPENTELEMETRY_LOGGING_URLkey was not consumed. Resource attributes are exported asOTEL_RESOURCE_ATTRIBUTES(key=value,key=value), read by the OpenTelemetry SDK and mapped as a string in the config.OPENTELEMETRY_LOGGING_ENABLEDandTELEMETRY_TRACING_ENABLEDare always exported with their value; urls only when enabled.global.telemetrywith the same hierarchy. Only the tracing and OTLP logger urls are overridable from global and take precedence over chart values; enabled flags stay chart-level.metricsvalues are removed as in the boilerplate: the configmap never rendered them, nothing in the service readstelemetry.metrics, and the pod Prometheus annotations come from mclabels.common.tracing.merged,common.metrics.mergedandcommon.openTelemetryOptions.mergedhelpers removed;tracingUrl,opentelemetryLoggingUrlandotelResourceAttributeshelpers added.config/custom-environment-variables.jsonmapstelemetry.logger.opentelemetryOptionsfromOPENTELEMETRY_LOGGING_ENABLED,OTLP_LOGGER_ENDPOINT_URLandOTEL_RESOURCE_ATTRIBUTES.Breaking for consumers: umbrella charts and site-values setting
env.port,env.targetPort,env.protocol,env.logLevel,env.logPrettyPrintEnabled,env.openTelemetryOptions.*,env.requestPayloadLimit,env.responseCompressionEnabled,tracing.*,metrics.*,global.tracing.*,global.metrics.*orglobal.openTelemetryOptions.*must move toserver.*,telemetry.*andglobal.telemetry.*;env.httpRetry,env.jobManagementandenv.disableHttpClientLogsremain valid paths. Known spots: raster-ingestionpolygon-parts-worker.mclabels.partOfandconfigManagement.offlineModeand raster-exportexporter-polygon-parts-worker.configManagement.offlineModecan be dropped (now defaults); the commented# env: logLevel: infoin site-valuesraster/export/*.yamlandraster/ingestion/*.yamlwould becometelemetry.logger.level.🤖 Generated with Claude Code