Skip to content

fix(helm): align values with ts-server-boilerplate server/telemetry split - #106

Open
CL-SHLOMIKONCHA wants to merge 5 commits into
masterfrom
fix/helm-default-values
Open

CL-SHLOMIKONCHA wants to merge 5 commits into
masterfrom
fix/helm-default-values

Conversation

@CL-SHLOMIKONCHA

@CL-SHLOMIKONCHA CL-SHLOMIKONCHA commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor
Question Answer
Bug fix ✔
New feature ✖
Breaking change ✔
Deprecations ✖
Documentation ✖
Tests added ✖
Chore ✖

Related issues: MAPCO-11633, MapColonies/ts-server-boilerplate#476 (MAPCO-11622), raster-export / raster-ingestion umbrella TODOs (helm-charts-new → charts/raster-export/values.yaml, charts/raster-ingestion/values.yaml). Supersedes the helm parts of #87.

Further information:

Default values

Value Before After
mclabels.partOf core ingestion (raster-ingestion TODO; raster-export keeps overriding to export)
configManagement.offlineMode true true (already default, umbrella TODO override can be dropped)
jobDefinitions.tasks.validation.reportsDownloadPath /downloads/validation-reports /validation-reports (matches the raster-ingestion override, which can be dropped)
telemetry.logger.opentelemetryOptions.enabled false true
telemetry.tracing.enabled false true

Server / telemetry split (mirrors ts-server-boilerplate#476)

  • The server and telemetry keys leave the flat env block: server scope (port, targetPort, protocol, requestPayloadLimit, responseCompressionEnabled) and telemetry scope (logger, tracing). The worker keys env.httpRetry, env.jobManagement and env.disableHttpClientLogs stay under env unchanged.
  • Logger keys renamed to level / prettyPrint; logger.opentelemetryOptions holds enabled, url and optional resourceAttributes.
  • The OTLP logger url is exported as OTLP_LOGGER_ENDPOINT_URL, the name the commonBoilerplateV3 schema reads; the previous OPENTELEMETRY_LOGGING_URL key was not consumed. Resource attributes are exported as OTEL_RESOURCE_ATTRIBUTES (key=value,key=value), read by the OpenTelemetry SDK and mapped as a string in the config.
  • OPENTELEMETRY_LOGGING_ENABLED and TELEMETRY_TRACING_ENABLED are always exported with their value; urls only when enabled.
  • Global overrides move under global.telemetry with the same hierarchy. Only the tracing and OTLP logger urls are overridable from global and take precedence over chart values; enabled flags stay chart-level.
  • The metrics values are removed as in the boilerplate: the configmap never rendered them, nothing in the service reads telemetry.metrics, and the pod Prometheus annotations come from mclabels.
  • common.tracing.merged, common.metrics.merged and common.openTelemetryOptions.merged helpers removed; tracingUrl, opentelemetryLoggingUrl and otelResourceAttributes helpers added.
  • config/custom-environment-variables.json maps telemetry.logger.opentelemetryOptions from OPENTELEMETRY_LOGGING_ENABLED, OTLP_LOGGER_ENDPOINT_URL and OTEL_RESOURCE_ATTRIBUTES.

Breaking for consumers: umbrella charts and site-values setting env.port, env.targetPort, env.protocol, env.logLevel, env.logPrettyPrintEnabled, env.openTelemetryOptions.*, env.requestPayloadLimit, env.responseCompressionEnabled, tracing.*, metrics.*, global.tracing.*, global.metrics.* or global.openTelemetryOptions.* must move to server.*, telemetry.* and global.telemetry.*; env.httpRetry, env.jobManagement and env.disableHttpClientLogs remain valid paths. Known spots: raster-ingestion polygon-parts-worker.mclabels.partOf and configManagement.offlineMode and raster-export exporter-polygon-parts-worker.configManagement.offlineMode can be dropped (now defaults); the commented # env: logLevel: info in site-values raster/export/*.yaml and raster/ingestion/*.yaml would become telemetry.logger.level.

🤖 Generated with Claude Code

CL-SHLOMIKONCHA and others added 3 commits September 10, 2026 15:21
Align the chart with ts-server-boilerplate:

- replace the server and telemetry keys of the flat env block with a
  server scope (port, targetPort, protocol, requestPayloadLimit,
  responseCompressionEnabled) and a telemetry scope (logger, tracing);
  the worker keys (httpRetry, jobManagement, disableHttpClientLogs) stay
  under env
- rename logger keys to level and prettyPrint to match the config schema
- export the otlp logger url as OTLP_LOGGER_ENDPOINT_URL and resource
  attributes as OTEL_RESOURCE_ATTRIBUTES in key=value,key=value format,
  the names the commonBoilerplateV3 schema and the OpenTelemetry SDK read
- move global overrides under global.telemetry; only the tracing and
  otlp logger urls are overridable from global and take precedence over
  chart values, enabled flags stay chart-level
- remove the metrics values and helpers, nothing rendered them; the pod
  prometheus annotations come from mclabels
- drop the merged tracing/metrics/openTelemetryOptions helpers

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Resolves the raster-ingestion umbrella TODO; the export umbrella keeps
overriding it to export.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Map opentelemetryOptions.url from OTLP_LOGGER_ENDPOINT_URL and
resourceAttributes from OTEL_RESOURCE_ATTRIBUTES, the names the helm
configmap now exports.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Matches the value the raster-ingestion umbrella already sets.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Aligns with ts-server-boilerplate#477: loggerConfig already carries prettyPrint,
so spreading it is enough.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants