helm: split server and telemetry values and fix default values (MAPCO-11633) - #179
Open
CL-SHLOMIKONCHA wants to merge 3 commits into
Open
CL-SHLOMIKONCHA wants to merge 3 commits into
CL-SHLOMIKONCHA wants to merge 3 commits into
Conversation
…-11633) Mirrors ts-server-boilerplate#476: server keys move to a `server` scope, logger/tracing keys to a `telemetry` scope, global overrides to `global.telemetry`. `env` keeps the mapproxy specific keys. The configmap exports OTLP_LOGGER_ENDPOINT_URL and OTEL_RESOURCE_ATTRIBUTES and always exports the telemetry enabled flags. Chart defaults folded in from the raster-ingestion umbrella TODOs: image.pullPolicy IfNotPresent (now templated), configManagement.offlineMode true, db.schema MapproxyConfig. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… and OTEL_RESOURCE_ATTRIBUTES Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Aligns with ts-server-boilerplate#477: loggerConfig already carries prettyPrint, so spreading it is enough. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: MAPCO-11633, MapColonies/ts-server-boilerplate#476 (MAPCO-11622), raster-ingestion umbrella TODOs (
helm-charts-new→charts/raster-ingestion/values.yaml, site-valuesraster/ingestion/{dev,qa}.yaml)Further information:
Default values
image.pullPolicyIfNotPresent(new, rendered asimagePullPolicy)configManagement.offlineModefalsetruedb.schema""MapproxyConfigtelemetry.logger.opentelemetryOptions.enabledfalsetruetelemetry.tracing.enabledfalsetrueThe TODO overrides in the raster-ingestion umbrella (
mapproxy-api.configManagement.offlineMode,mapproxy-api.db.schema) and the "no image pull policy set for this container inside service" TODO in the umbrella and in site-values dev/qa can be dropped.Server / telemetry split (mirrors ts-server-boilerplate#476)
envblock: aserverscope (port,targetPort,protocol,requestPayloadLimit,responseCompressionEnabled) and atelemetryscope (logger,tracing). The top-leveltracingblock is gone. The mapproxy-api specific key (mapproxyCache) stays underenvunchanged.level/prettyPrint;logger.opentelemetryOptionsholdsenabled,urland optionalresourceAttributes.OTLP_LOGGER_ENDPOINT_URL, the name thecommonBoilerplateV3schema reads; the previousOPENTELEMETRY_LOGGING_URLkey was not consumed. Resource attributes are exported asOTEL_RESOURCE_ATTRIBUTES(key=value,key=value), read by the OpenTelemetry SDK and mapped as a string in the config.OPENTELEMETRY_LOGGING_ENABLEDandTELEMETRY_TRACING_ENABLEDare always exported with their value; urls only when enabled.TELEMETRY_TRACING_URLis now quoted.global.telemetrywith the same hierarchy. Only the tracing and OTLP logger urls are overridable from global and take precedence over chart values; enabled flags stay chart-level.common.tracing.mergedandcommon.openTelemetryOptions.mergedhelpers removed, along with the unusedmetricsUrlhelper (it referencedenv.metrics, which never existed in this chart);tracingUrl,opentelemetryLoggingUrlandotelResourceAttributeshelpers added.config/custom-environment-variables.jsonmapstelemetry.logger.opentelemetryOptionsfromOPENTELEMETRY_LOGGING_ENABLED,OTLP_LOGGER_ENDPOINT_URLandOTEL_RESOURCE_ATTRIBUTES.Breaking for consumers: umbrella charts and site-values setting
env.port,env.targetPort,env.protocol,env.logLevel,env.logPrettyPrintEnabled,env.openTelemetryOptions.*,env.responseCompressionEnabled,env.requestPayloadLimit,tracing.*,global.tracing.*orglobal.openTelemetryOptions.*must move toserver.*,telemetry.*andglobal.telemetry.*.env.logLevel: infoin site-valuesraster/ingestion/dev.yamlandqa.yamlbecomestelemetry.logger.level: info.env.mapproxyCache.*keeps its path.🤖 Generated with Claude Code