Skip to content

helm: split server and telemetry values and fix default values (MAPCO-11633) - #179

Open
CL-SHLOMIKONCHA wants to merge 3 commits into
masterfrom
fix/helm-default-values
Open

CL-SHLOMIKONCHA wants to merge 3 commits into
masterfrom
fix/helm-default-values

Conversation

@CL-SHLOMIKONCHA

Copy link
Copy Markdown
Collaborator
Question Answer
Bug fix ✔
New feature ✖
Breaking change ✔
Deprecations ✖
Documentation ✖
Tests added ✖
Chore ✖

Related issues: MAPCO-11633, MapColonies/ts-server-boilerplate#476 (MAPCO-11622), raster-ingestion umbrella TODOs (helm-charts-new → charts/raster-ingestion/values.yaml, site-values raster/ingestion/{dev,qa}.yaml)

Further information:

Default values

Key Before After
image.pullPolicy not templated (cluster default) IfNotPresent (new, rendered as imagePullPolicy)
configManagement.offlineMode false true
db.schema "" MapproxyConfig
telemetry.logger.opentelemetryOptions.enabled false true
telemetry.tracing.enabled false true

The TODO overrides in the raster-ingestion umbrella (mapproxy-api.configManagement.offlineMode, mapproxy-api.db.schema) and the "no image pull policy set for this container inside service" TODO in the umbrella and in site-values dev/qa can be dropped.

Server / telemetry split (mirrors ts-server-boilerplate#476)

  • The server and telemetry keys leave the flat env block: a server scope (port, targetPort, protocol, requestPayloadLimit, responseCompressionEnabled) and a telemetry scope (logger, tracing). The top-level tracing block is gone. The mapproxy-api specific key (mapproxyCache) stays under env unchanged.
  • Logger keys renamed to level / prettyPrint; logger.opentelemetryOptions holds enabled, url and optional resourceAttributes.
  • The OTLP logger url is exported as OTLP_LOGGER_ENDPOINT_URL, the name the commonBoilerplateV3 schema reads; the previous OPENTELEMETRY_LOGGING_URL key was not consumed. Resource attributes are exported as OTEL_RESOURCE_ATTRIBUTES (key=value,key=value), read by the OpenTelemetry SDK and mapped as a string in the config.
  • OPENTELEMETRY_LOGGING_ENABLED and TELEMETRY_TRACING_ENABLED are always exported with their value; urls only when enabled. TELEMETRY_TRACING_URL is now quoted.
  • Global overrides move under global.telemetry with the same hierarchy. Only the tracing and OTLP logger urls are overridable from global and take precedence over chart values; enabled flags stay chart-level.
  • common.tracing.merged and common.openTelemetryOptions.merged helpers removed, along with the unused metricsUrl helper (it referenced env.metrics, which never existed in this chart); tracingUrl, opentelemetryLoggingUrl and otelResourceAttributes helpers added.
  • config/custom-environment-variables.json maps telemetry.logger.opentelemetryOptions from OPENTELEMETRY_LOGGING_ENABLED, OTLP_LOGGER_ENDPOINT_URL and OTEL_RESOURCE_ATTRIBUTES.

Breaking for consumers: umbrella charts and site-values setting env.port, env.targetPort, env.protocol, env.logLevel, env.logPrettyPrintEnabled, env.openTelemetryOptions.*, env.responseCompressionEnabled, env.requestPayloadLimit, tracing.*, global.tracing.* or global.openTelemetryOptions.* must move to server.*, telemetry.* and global.telemetry.*. env.logLevel: info in site-values raster/ingestion/dev.yaml and qa.yaml becomes telemetry.logger.level: info. env.mapproxyCache.* keeps its path.

🤖 Generated with Claude Code

CL-SHLOMIKONCHA and others added 3 commits September 10, 2026 15:56
…-11633)

Mirrors ts-server-boilerplate#476: server keys move to a `server` scope,
logger/tracing keys to a `telemetry` scope, global overrides to
`global.telemetry`. `env` keeps the mapproxy specific keys. The configmap
exports OTLP_LOGGER_ENDPOINT_URL and OTEL_RESOURCE_ATTRIBUTES and always
exports the telemetry enabled flags.

Chart defaults folded in from the raster-ingestion umbrella TODOs:
image.pullPolicy IfNotPresent (now templated), configManagement.offlineMode
true, db.schema MapproxyConfig.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… and OTEL_RESOURCE_ATTRIBUTES

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Aligns with ts-server-boilerplate#477: loggerConfig already carries prettyPrint,
so spreading it is enough.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant