Conversation
razbroc
force-pushed
the
feat/get-cache-geopackage-coverage
branch
from
August 24, 2026 13:33
75382d7 to
d724a5c
Compare
almog8k
approved these changes
Sep 2, 2026
almog8k
force-pushed
the
feat/get-cache-geopackage-coverage
branch
from
September 2, 2026 07:15
d724a5c to
adc02fa
Compare
geopackage is an accepted cacheType, and its response schema now exists, but no geopackage Cache existed in any fixture - so nothing proved a real geopackage response satisfies the contract. The live dev configuration holds no geopackage Cache either, so the fixture Cache Source is derived from GpkgSource. Verified that this test fails against the pre-loosening contract with 'cache must match exactly one schema in oneOf'.
razbroc
force-pushed
the
feat/get-cache-geopackage-coverage
branch
from
September 6, 2026 10:51
adc02fa to
71735a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: MAPCO-11508
Further information:
Second PR on MAPCO-11508. Stacked on #175 — review and merge that first; this PR targets its branch, and its diff will reduce to one commit once #175 lands.
geopackageis an acceptedcacheType, and #175 publishes its response schema, but no geopackage Cache existed in any fixture — so nothing proved that a real geopackage response satisfies the contract. The live dev configuration holds no geopackage Cache either, so the fixture's Cache Source is derived fromGpkgSourcerather than copied from an environment.Verified that this test fails against the pre-loosening contract with
cache must match exactly one schema in oneOf— so #175's schema commit is proved by this test rather than asserting itself.