feat: handle Delete_Layer tasks flow (MAPCO-10814) - #72
Merged
Merged
Conversation
roicohen326
commented
Jul 15, 2026
roicohen326
commented
Contributor
| Question | Answer |
|---|---|
| Bug fix | ✖ |
| New feature | ✔ |
| Breaking change | ✖ |
| Deprecations | ✖ |
| Documentation | ✖ |
| Tests added | ✖ |
| Chore | ✖ |
Add a DeleteLayerJobHandler for the new Delete_Layer job type, wiring its task flow (delete -> tiles-deletion -> artifacts-deletion -> finalize) through config, helm, and the job handler factory. The tiles-deletion and artifacts-deletion tasks are excluded from auto-creation since another service creates them with real per-layer parameters job-tracker doesn't have. Bumps @map-colonies/raster-shared to 8.3.0-alpha.0 (exact pin, matching ingestion-trigger) since the deletion types are only available on the alpha track.
Cover the cross-repo context, the generic job/task engine, the design rationale behind the new handler, config wiring across all four layers, the raster-shared alpha-pin situation, and the test strategy.
A separate, jargon-free doc explaining what job-tracker does, what a "handler" is, and what changed for Delete_Layer — for anyone who wants the gist without the code-level deep-dive.
This reverts commit 1d7c500.
Delete_Layer tasks are all created externally - job-tracker no longer creates any task for this job type. The job completes when all tasks are done (isJobCompleted override, like the seed handler).
A tiles-deletion task always follows delete, so the job completes only when all tasks are done and the completed notification is for tiles-deletion - a completed delete alone never completes the job.
…_DELETION JOB_DEFINITIONS_TASK_DELETION was easily confused with JOB_DEFINITIONS_TASK_DELETE (the delete task).
Remove redundant pending-deletion-tasks progress test (only one delete task ever exists) and add a failed tiles-deletion task scenario.
CL-SHLOMIKONCHA
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.