helm: split server and telemetry values and fix default values (MAPCO-11633) - #106
Open
CL-SHLOMIKONCHA wants to merge 4 commits into
Open
CL-SHLOMIKONCHA wants to merge 4 commits into
CL-SHLOMIKONCHA wants to merge 4 commits into
Conversation
The raster-ingestion umbrella chart and site-values override imagePullPolicy to IfNotPresent and configManagement.offlineMode to true on every deployment. Make them the chart defaults so the overrides can be removed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Align the chart with ts-server-boilerplate: - replace the flat env block with a server scope (port, targetPort, protocol, requestPayloadLimit, responseCompressionEnabled) and a telemetry scope (logger, tracing); the ingestion-trigger specific keys stay under env - rename logger keys to level and prettyPrint to match the config schema - export the otlp logger url as OTLP_LOGGER_ENDPOINT_URL and resource attributes as OTEL_RESOURCE_ATTRIBUTES in key=value,key=value format, the names the commonBoilerplateV3 schema and the OpenTelemetry SDK read - always export OPENTELEMETRY_LOGGING_ENABLED and TELEMETRY_TRACING_ENABLED with their value - move global overrides under global.telemetry; only the tracing and otlp logger urls are overridable from global and take precedence over chart values, enabled flags stay chart-level - drop the top-level tracing block, env.tracing and the common.tracing.merged / common.openTelemetryOptions.merged helpers - reference server.* in the deployment, service and ingress templates Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… env names Read telemetry.logger.opentelemetryOptions.url from OTLP_LOGGER_ENDPOINT_URL and resourceAttributes from OTEL_RESOURCE_ATTRIBUTES, matching the helm configmap and the commonBoilerplateV3 schema. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
almog8k
approved these changes
Sep 14, 2026
Aligns with ts-server-boilerplate#477: loggerConfig already carries prettyPrint, so spreading it is enough. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: MAPCO-11633, MapColonies/ts-server-boilerplate#476 (MAPCO-11622), raster-ingestion umbrella TODOs (
helm-charts-new→charts/raster-ingestion/values.yaml)Further information:
Default values
imagePullPolicyAlwaysIfNotPresentconfigManagement.offlineModefalsetruetelemetry.logger.opentelemetryOptions.enabledfalsetruetelemetry.tracing.enabledfalsetrueBoth TODO overrides in the raster-ingestion umbrella (
ingestion-trigger.imagePullPolicy,ingestion-trigger.configManagement.offlineMode) can be dropped, as caningestion-trigger.imagePullPolicy: IfNotPresentin site-valuesraster/ingestion/qa.yaml, which is now the default.Server / telemetry split (mirrors ts-server-boilerplate#476)
envblock: aserverscope (port,targetPort,protocol,requestPayloadLimit,responseCompressionEnabled) and atelemetryscope (logger,tracing). The ingestion-trigger specific keys (storageExplorer,validationValuesByInfo,disableHttpClientLogs,httpRetry,productReader,supportedIngestionSwapTypes,forbiddenJobTypesForParallelIngestion,deleteLayer) stay underenvunchanged.level/prettyPrint;logger.opentelemetryOptionsholdsenabled,urland optionalresourceAttributes.OTLP_LOGGER_ENDPOINT_URL, the name thecommonBoilerplateV3schema reads; the previousOPENTELEMETRY_LOGGING_URLkey was not consumed. Resource attributes are exported asOTEL_RESOURCE_ATTRIBUTES(key=value,key=value), read by the OpenTelemetry SDK and mapped as a string in the config.OPENTELEMETRY_LOGGING_ENABLEDandTELEMETRY_TRACING_ENABLEDare always exported with their value; urls only when enabled.global.telemetrywith the same hierarchy. Only the tracing and OTLP logger urls are overridable from global and take precedence over chart values; enabled flags stay chart-level.tracingblock and the duplicateenv.tracingblock are removed together with thecommon.tracing.mergedandcommon.openTelemetryOptions.mergedhelpers;tracingUrl,opentelemetryLoggingUrlandotelResourceAttributeshelpers added.config/custom-environment-variables.jsonmapstelemetry.logger.opentelemetryOptionsfromOPENTELEMETRY_LOGGING_ENABLED,OTLP_LOGGER_ENDPOINT_URLandOTEL_RESOURCE_ATTRIBUTES.Breaking for consumers: umbrella charts and site-values setting
env.port,env.targetPort,env.protocol,env.logLevel,env.logPrettyPrintEnabled,env.openTelemetryOptions.*,env.responseCompressionEnabled,env.requestPayloadLimit,env.tracing.*,tracing.*,global.tracing.*orglobal.openTelemetryOptions.*must move toserver.*,telemetry.*andglobal.telemetry.*.env.productReader.maxVerticesPerChunkandenv.supportedIngestionSwapTypes(raster-ingestion umbrella) keep their paths. The commentedenv.logLevelin site-values dev/qa would becometelemetry.logger.level.🤖 Generated with Claude Code