feat(helm): detect image references anywhere in a values file - #35
Merged
CptSchnitz merged 1 commit intoSep 14, 2026
Merged
Conversation
Detection was previously narrow, matching only a mapping with both a sibling repository and tag key. Generalise it to be structural: any mapping carrying a repository key is a candidate, corroborated by a sibling tag, pullPolicy or registry key, or by a parent key of image or one ending in Image. This catches references at any depth and parent-key naming without requiring a chart to follow a convention. A tag sibling is now optional rather than required. A reference with no tag key is reported as tagless (tag: undefined) instead of being dropped, since resolving it through the chart's appVersion is a later ticket's job. extension.ts filters tagless references out before existence checks accordingly, since there is nothing to check yet. A repository or tag whose raw text carries unresolved Helm template syntax is skipped: a templated repository drops the whole candidate, a templated tag is treated as tagless. Refs #20
CptSchnitz
force-pushed
the
ticket-20/structural-image-reference-detection
branch
from
September 14, 2026 04:46
75cbe44 to
ac62490
Compare
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Generalizes
extractImageReferences(packages/helm) from matching only a conventional siblingrepository+tagpair to structural detection: any mapping carrying arepositorykey, at any depth, corroborated by a siblingtag,pullPolicyorregistrykey, or a parent key ofimageor one ending inImage.tagis now optional onImageReference. A mapping with notagkey (or an emptytag:) reports as tagless (tag: undefined) instead of being dropped — resolving it through the chart'sappVersionis a later ticket.repositoryortagwhose raw text contains unresolved Helm template syntax ({{ ... }}) is skipped: a templated repository drops the whole candidate, a templated tag is treated as tagless.repository:) is treated as absent, not as an empty-string value.apps/vscode/src/extension.tsfilters out tagless references before existence checks, since there's nothing to check yet.Closes #20
Testing
packages/helm: 25 tests covering every acceptance criterion (structural detection at depth, each corroborating signal independently, tagless reporting, template-syntax skipping, empty-scalar handling, multi-reference source ranges).build,lint,type-check,testviaturbopass.