Conversation
Picks up the mapproxinator.tracing.url override added in MapColonies/docker-mapproxy#103, which lets the mapproxy and mapproxinator containers point at different OTLP endpoints. mapproxy exports over gRPC (:4317) and mapproxinator over HTTP (:4318/v1/traces); until now both rendered from a single tracing.url, so one of them always dropped spans. Chart version is left to release-please.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the
mapproxydependency incharts/raster-serving/Chart.yamlfrom2.1.3to2.2.0.Why
The mapproxy chart renders two containers from a single merged
tracing.url, but they do not speak the same OTLP transport:mapproxy(python)opentelemetry.exporter.otlp.proto.grpchost:4317, no pathmapproxinator(node)@opentelemetry/exporter-trace-otlp-proto(HTTP)host:4318/v1/tracesSo whichever port is configured, one container silently drops every span. Confirmed on the live
raster-devdeployment: probing from inside the running mapproxinator container returnedFAILED (HPE_INVALID_CONSTANT)against:4317andHTTP 200against:4318/v1/traces, while mapproxy logged[otel-probe] collector REACHABLE at ...:4317.MapColonies/docker-mapproxy#103 adds an opt-in
mapproxinator.tracing.urlthat overrides the shared endpoint for that container only. This bump makes it available toraster-servingconsumers.Version note
2.2.0assumes #103 lands as afeatunder release-please. If a reviewer retitles it tofix, this becomes2.1.4and I will update this PR.The chart's own
version:is untouched -charts/raster-servingis a release-please package (release-type: helm), so it owns that bump.Verification
None possible yet:
helm dependency buildcannot resolve2.2.0until it is published. This PR stays a draft until then, at which point I will validate and mark it ready.Chain