Skip to content

fix(helm): align values with ts-server-boilerplate server/telemetry split - #152

Open
CL-SHLOMIKONCHA wants to merge 5 commits into
masterfrom
fix/helm-default-values
Open

CL-SHLOMIKONCHA wants to merge 5 commits into
masterfrom
fix/helm-default-values

Conversation

@CL-SHLOMIKONCHA

@CL-SHLOMIKONCHA CL-SHLOMIKONCHA commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor
Question Answer
Bug fix ✔
New feature ✖
Breaking change ✔
Deprecations ✖
Documentation ✖
Tests added ✖
Chore ✖

Related issues: MAPCO-11633, MapColonies/ts-server-boilerplate#476 (MAPCO-11622), raster-export umbrella TODOs (helm-charts-new → charts/raster-export/values.yaml)

Further information:

Default values

Key Before After
imagePullPolicy Always IfNotPresent
configManagement.offlineMode false true
route.enabled true false
telemetry.logger.opentelemetryOptions.enabled false true
telemetry.tracing.enabled false true

Both TODO overrides in the raster-export umbrella (exporter-trigger.imagePullPolicy, exporter-trigger.configManagement.offlineMode) can be dropped, as can exporter-trigger.route.enabled: false in site-values raster/export/base.yaml.gotmpl, which is now the default.

Server / telemetry split (mirrors ts-server-boilerplate#476)

  • The server and telemetry keys leave the flat env block: a server scope (port, targetPort, protocol, requestPayloadLimit, responseCompressionEnabled) and a telemetry scope (logger, tracing). The exporter-trigger specific keys (disableHttpClientLogs, cleanupExpirationDays, httpRetry, estimatedStorageCalculation, roiBufferMeter, minContainedPercentage) stay under env unchanged.
  • Logger keys renamed to level / prettyPrint; logger.opentelemetryOptions holds enabled, url and optional resourceAttributes.
  • The OTLP logger url is exported as OTLP_LOGGER_ENDPOINT_URL, the name the commonBoilerplateV3 schema reads; the previous OPENTELEMETRY_LOGGING_URL key was not consumed. Resource attributes are exported as OTEL_RESOURCE_ATTRIBUTES (key=value,key=value), read by the OpenTelemetry SDK and mapped as a string in the config.
  • OPENTELEMETRY_LOGGING_ENABLED and TELEMETRY_TRACING_ENABLED are always exported with their value; urls only when enabled.
  • Global overrides move under global.telemetry with the same hierarchy. Only the tracing and OTLP logger urls are overridable from global and take precedence over chart values; enabled flags stay chart-level.
  • common.tracing.merged and common.openTelemetryOptions.merged helpers removed; tracingUrl, opentelemetryLoggingUrl and otelResourceAttributes helpers added.
  • server.port (80) replaces env.internalPort as the service port. The ingress backend now targets that service port instead of the container port (env.port 8080, removed), which is what the service actually exposes.
  • config/custom-environment-variables.json maps telemetry.logger.opentelemetryOptions from OPENTELEMETRY_LOGGING_ENABLED, OTLP_LOGGER_ENDPOINT_URL and OTEL_RESOURCE_ATTRIBUTES.

Breaking for consumers: umbrella charts and site-values setting env.port, env.targetPort, env.internalPort, env.logLevel, env.logPrettyPrintEnabled, env.openTelemetryOptions.*, env.responseCompressionEnabled, env.requestPayloadLimit, tracing.*, global.tracing.* or global.openTelemetryOptions.* must move to server.*, telemetry.* and global.telemetry.*. env.cleanupExpirationDays (site-values raster/export/qa.yaml) and the other exporter-trigger env.* keys keep their paths. The commented env.logLevel in site-values dev/qa would become telemetry.logger.level.

🤖 Generated with Claude Code

CL-SHLOMIKONCHA and others added 5 commits September 10, 2026 15:19
Default imagePullPolicy to IfNotPresent and configManagement.offlineMode
to true so the raster-export umbrella no longer needs to override them.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Align the chart with ts-server-boilerplate:

- replace the server and telemetry keys of the flat env block with a
  server scope (port, targetPort, protocol, requestPayloadLimit,
  responseCompressionEnabled) and a telemetry scope (logger, tracing);
  the exporter-trigger specific keys stay under env
- rename logger keys to level and prettyPrint to match the config schema
- export the otlp logger url as OTLP_LOGGER_ENDPOINT_URL and resource
  attributes as OTEL_RESOURCE_ATTRIBUTES in key=value,key=value format,
  the names the commonBoilerplateV3 schema and the OpenTelemetry SDK read
- always export the tracing and otlp logging enabled flags
- move global overrides under global.telemetry; only the tracing and
  otlp logger urls are overridable from global and take precedence over
  chart values, enabled flags stay chart-level
- drop the common.tracing.merged and common.openTelemetryOptions.merged
  helpers
- service, ingress and deployment read ports from server.*; the ingress
  backend now targets the service port instead of the container port

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Map telemetry.logger.opentelemetryOptions.url from
OTLP_LOGGER_ENDPOINT_URL and resourceAttributes from
OTEL_RESOURCE_ATTRIBUTES, matching the helm configmap and the
commonBoilerplateV3 schema.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Aligns with ts-server-boilerplate#477: loggerConfig already carries prettyPrint,
so spreading it is enough.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant