fix(helm): align values with ts-server-boilerplate server/telemetry split - #152
Open
CL-SHLOMIKONCHA wants to merge 5 commits into
Open
CL-SHLOMIKONCHA wants to merge 5 commits into
CL-SHLOMIKONCHA wants to merge 5 commits into
Conversation
Default imagePullPolicy to IfNotPresent and configManagement.offlineMode to true so the raster-export umbrella no longer needs to override them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Align the chart with ts-server-boilerplate: - replace the server and telemetry keys of the flat env block with a server scope (port, targetPort, protocol, requestPayloadLimit, responseCompressionEnabled) and a telemetry scope (logger, tracing); the exporter-trigger specific keys stay under env - rename logger keys to level and prettyPrint to match the config schema - export the otlp logger url as OTLP_LOGGER_ENDPOINT_URL and resource attributes as OTEL_RESOURCE_ATTRIBUTES in key=value,key=value format, the names the commonBoilerplateV3 schema and the OpenTelemetry SDK read - always export the tracing and otlp logging enabled flags - move global overrides under global.telemetry; only the tracing and otlp logger urls are overridable from global and take precedence over chart values, enabled flags stay chart-level - drop the common.tracing.merged and common.openTelemetryOptions.merged helpers - service, ingress and deployment read ports from server.*; the ingress backend now targets the service port instead of the container port Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Map telemetry.logger.opentelemetryOptions.url from OTLP_LOGGER_ENDPOINT_URL and resourceAttributes from OTEL_RESOURCE_ATTRIBUTES, matching the helm configmap and the commonBoilerplateV3 schema. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Aligns with ts-server-boilerplate#477: loggerConfig already carries prettyPrint, so spreading it is enough. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: MAPCO-11633, MapColonies/ts-server-boilerplate#476 (MAPCO-11622), raster-export umbrella TODOs (
helm-charts-new→charts/raster-export/values.yaml)Further information:
Default values
imagePullPolicyAlwaysIfNotPresentconfigManagement.offlineModefalsetrueroute.enabledtruefalsetelemetry.logger.opentelemetryOptions.enabledfalsetruetelemetry.tracing.enabledfalsetrueBoth TODO overrides in the raster-export umbrella (
exporter-trigger.imagePullPolicy,exporter-trigger.configManagement.offlineMode) can be dropped, as canexporter-trigger.route.enabled: falsein site-valuesraster/export/base.yaml.gotmpl, which is now the default.Server / telemetry split (mirrors ts-server-boilerplate#476)
envblock: aserverscope (port,targetPort,protocol,requestPayloadLimit,responseCompressionEnabled) and atelemetryscope (logger,tracing). The exporter-trigger specific keys (disableHttpClientLogs,cleanupExpirationDays,httpRetry,estimatedStorageCalculation,roiBufferMeter,minContainedPercentage) stay underenvunchanged.level/prettyPrint;logger.opentelemetryOptionsholdsenabled,urland optionalresourceAttributes.OTLP_LOGGER_ENDPOINT_URL, the name thecommonBoilerplateV3schema reads; the previousOPENTELEMETRY_LOGGING_URLkey was not consumed. Resource attributes are exported asOTEL_RESOURCE_ATTRIBUTES(key=value,key=value), read by the OpenTelemetry SDK and mapped as a string in the config.OPENTELEMETRY_LOGGING_ENABLEDandTELEMETRY_TRACING_ENABLEDare always exported with their value; urls only when enabled.global.telemetrywith the same hierarchy. Only the tracing and OTLP logger urls are overridable from global and take precedence over chart values; enabled flags stay chart-level.common.tracing.mergedandcommon.openTelemetryOptions.mergedhelpers removed;tracingUrl,opentelemetryLoggingUrlandotelResourceAttributeshelpers added.server.port(80) replacesenv.internalPortas the service port. The ingress backend now targets that service port instead of the container port (env.port8080, removed), which is what the service actually exposes.config/custom-environment-variables.jsonmapstelemetry.logger.opentelemetryOptionsfromOPENTELEMETRY_LOGGING_ENABLED,OTLP_LOGGER_ENDPOINT_URLandOTEL_RESOURCE_ATTRIBUTES.Breaking for consumers: umbrella charts and site-values setting
env.port,env.targetPort,env.internalPort,env.logLevel,env.logPrettyPrintEnabled,env.openTelemetryOptions.*,env.responseCompressionEnabled,env.requestPayloadLimit,tracing.*,global.tracing.*orglobal.openTelemetryOptions.*must move toserver.*,telemetry.*andglobal.telemetry.*.env.cleanupExpirationDays(site-valuesraster/export/qa.yaml) and the other exporter-triggerenv.*keys keep their paths. The commentedenv.logLevelin site-values dev/qa would becometelemetry.logger.level.🤖 Generated with Claude Code