docs(dem): v2 (MAPCO-8937) by shimoncohen · Pull Request #163 · MapColonies/developer-portal

shimoncohen · 2026-02-17T14:16:54Z

No description provided.

github-actions · 2026-02-17T14:20:05Z

PR Preview Action v1.8.1
🚀 View preview at https://MapColonies.github.io/developer-portal/pr-preview/pr-163/
Built to branch `gh-pages` at 2026-09-28 11:35 UTC. Preview will be ready when the GitHub Pages deployment is complete.

asafmas-rnd · 2026-06-07T12:54:02Z

@@ -0,0 +1,965 @@
+---


Decide if and where to put the WFS section

vitaligi

~~please also fix Catalogue typo in '../DEM/Services/catalog/dem-catalog'~~
ignore

vitaligi · 2026-07-12T19:22:58Z

+            <mc:links scheme="WCS" name="product-DSM" description="">{WCS_SERVICE_URL}/wcs?request=GetCapabilities</mc:links>
+            <mc:links scheme="WCS_BASE" name="product-DSM" description="">{WCS_SERVICE_URL}/wcs</mc:links>
+            <mc:links scheme="WFS_BASE" name="product-DSM" description="">{WFS_SERVICE_URL}/wfs?request=GetCapabilities</mc:links>


i don't recall we talked on the schemes mentioned here, WCS seems duplicate

@asafmas-rnd We have WCS_BASE in our production too, we can think if we want to remove it.
I agree that going through the capabilities is the right call in general.

asafmas-rnd · 2026-07-13T06:43:11Z

@@ -42,7 +42,7 @@ flowchart LR

 Query **3D CSW catalog** service to find item(s) according to desired filter [example are here](/docs/ogc/protocols/ogc-csw/ogc-csw-examples)


This button sends to 3D getting started

This button also sends to 3D getting started

Why is it under the 3D section?

Why is the Raster title not "Getting started", and the 3D is?

Respond to each in a new comment, this isn't ok. And leave irrelevant things out of this PR.

Terrain provider is part of 3d and will stay that way.

asafmas-rnd · 2026-07-13T06:52:31Z

+
+:::warning
+
+Currently the terrain provider is only available through the `3D catalog`.


That's not true in the "prod" environment, as we have several QMesh layers in the DEM catalog

It is true. They are used for heights, not terrain.

asafmas-rnd · 2026-07-13T06:55:48Z

+| **Field name / Partial name** | **Filter purpose** |
+| ----------- | ----------- |
+| footprint | Specific geographical area |
+| ...Accuracy... | |


Please put valid values

Why? Values shouldn't be here, they are in the catalog.

Merge dup added/removed field blocks into main tables. v2 gets a "Changes from last version" column (🆕), v1 gets "Changes in next version" (🗑️) — single source of truth per field instead of two tables listing the same rows. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

shimoncohen

Traced the guides step-by-step against dem-dev (helm-charts#684). WCS flow holds; catalog step issues below, plus deployment-side findings on helm-charts#684.

shimoncohen · 2026-09-24T12:57:33Z

+                        <PropertyName>mc:productType</PropertyName>
+                        <Literal>DTM</Literal>
+                    </PropertyIsEqualTo>
+                    <ogc:Intersects>


Fails against dem-dev pycsw v2: Invalid gml:LineString geometry. Missing gml:posList. The GML2 outerBoundaryIs/coordinates form isn't accepted; use GML3 gml:exterior > gml:LinearRing > gml:posList (lat lon order for EPSG:4326). Verified the GML3 form returns results.

shimoncohen · 2026-09-24T12:57:33Z

+                <mc:productVersion>1</mc:productVersion>
+                <mc:region>region</mc:region>
+                <mc:sensors>sensors</mc:sensors>
+                <mc:srsId>srs_id</mc:srsId>


srs_id placeholder; other examples use 4326. Same in download/README.md.

shimoncohen · 2026-09-24T12:57:33Z

+            <mc:productVersion>1</mc:productVersion>
+            <mc:region>region</mc:region>
+            <mc:sensors>sensors</mc:sensors>
+            <mc:srsId>srs_id</mc:srsId>


srs_id placeholder; should be 4326 like the other examples.

shimoncohen · 2026-09-24T12:57:33Z

+                <mc:id>d2d812ba-40b7-4dfe-b3e7-869356467d3a</mc:id>
+                <mc:ingestionDateUTC>2025-12-31T09:55:51Z</mc:ingestionDateUTC>
+                <mc:insertDateUTC>2025-12-31T11:00:00Z</mc:insertDateUTC>
+                <mc:links scheme="WCS" name="srtm30-DSM" description="">{WCS_SERVICE_URL}/wcs?request=GetCapabilities</mc:links>


Links named srtm30-DSM on a record with productType DTM.

shimoncohen · 2026-09-24T12:57:33Z

+    end
+
+    c[<b>Step 1</b><br/>Catalog] --> d
+    d[<b>Step 2</b><br/>Get Capabilities] --> e


GetCapabilities and DescribeCoverage are both labelled "Step 2" while the sections treat them as parts of Step 2; also no Metadata edge into GetCapabilities.

shimoncohen · 2026-09-24T12:57:33Z

+| 🆕 | mc:maxAbsoluteAccuracyLEP90 | double | LEP90 max absolute vertical plane accuracy range in meters |
+| 🆕 | mc:minRelativeAccuracyLEP90 | double | LEP90 min relative vertical plane accuracy range in meters |
+| 🆕 | mc:maxRelativeAccuracyLEP90 | double | LEP90 max relative vertical plane accuracy range in meters |
+| 🆕 | mc:minHorizontalAccuracyCEP90 | double | |


mc:min/maxHorizontalAccuracyCEP90 have no description.

shimoncohen · 2026-09-24T12:57:33Z

+In the Response, look for desired data according to profile definition.
+
+## Get terrain provider URI (Step 2.1) {#step-2.1}
+In the Response, look for a `link` tag with `schem="TERRAIN_QMESH"`, this will be the link you need to get the data.


Typo: schem= → scheme=.

shimoncohen · 2026-09-24T12:57:33Z

+
+```javascript
+// **Optional** add to Cesium terrain provider in order to clamp 3d models to the ground or investigate terrain
+viewer.terrainProvider = new Cesium.TerrainProvider({


Cesium.TerrainProvider is an abstract interface, not constructible. Use Cesium.CesiumTerrainProvider.fromUrl(resource) (or new Cesium.CesiumTerrainProvider({ url }) on older Cesium). Also line 164 "v84": Cesium versions are 1.x, which one is meant?

shimoncohen · 2026-09-24T12:57:33Z

+The following guide will help you understand, ***Step-by-step*** how to add a `terrain provider` to your application.
+
+## Flow diagram
+```mermaid


Diagram has a "STEP 3.1" node but there's no Step 3.1 section (Cesium is under Step 3).

The GML2 outerBoundaryIs/coordinates polygon is rejected by the catalog ("Missing gml:posList"); the GML3 exterior/posList form was verified on dem-dev. productSubType is a declared v2 queryable (helm-charts#684 mappings.py / mc_dem profile) missing from the table. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

shimoncohen · 2026-09-24T14:02:38Z

Pushed 29d4148 from a /generate-docs run on helm-charts#684 (dem-dev):

Polygon tab: GML3 gml:exterior/gml:posList (lat lon); verified live.
profile_v2_0.md: added mc:productSubType (declared v2 queryable). Type/description taken from the 3D profile; not verifiable on dem-dev until v2 pycsw reads a v2-schema DB (see helm-charts#684). Please confirm.
mc:BoundingBox kept: v2 pycsw rejects the declared mc:boundingBox in spatial filters and accepts mc:BoundingBox.
Catalog v2 examples still unverifiable on dem-dev: /api/dem/v2 currently proxies to the v1 pycsw (helm-charts#684).

- height_extraction: coverageId prefix note is WCS-version specific (dem: in 1.0.0 and 2.0.1, dem__ only in 2.0.1); typos; srsId example - terrain_provider: terrain link is in the DEM catalog too; scheme= typo; link name matches live records; Cesium fromUrl (min 1.104) - CesiumTerrainProvider: replace removed url option and readyPromise with fromUrl; terrainProvider is set on viewer, not viewer.scene - download: srsId example Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

shimoncohen added 4 commits February 15, 2026 13:47

docs(dem): v2 WIP

9f0baeb

docs(dem): v2 WIP

979d501

docs(dem): v2 WIP

a3d5b0d

docs(dem): v2

463b187

shimoncohen requested review from asafMasa and vitaligi February 17, 2026 14:16

shimoncohen self-assigned this Feb 17, 2026

shimoncohen added the documentation Improvements or additions to documentation label Feb 17, 2026

shimoncohen changed the title ~~docs(dem): v2~~ docs(dem): v2 (MAPCO-8937) Feb 17, 2026

docs(dem): fix broken links

88f7eac

vitaligi requested changes Feb 17, 2026

View reviewed changes

asafmas-rnd requested changes Feb 18, 2026

View reviewed changes

Comment thread docs/MapColonies/DEM/Guides/height_extraction.md

Comment thread docs/MapColonies/DEM/Guides/height_extraction.md

Comment thread docs/MapColonies/DEM/Guides/height_extraction.md Outdated

Comment thread docs/MapColonies/DEM/Guides/height_extraction.md

shimoncohen added 3 commits February 19, 2026 14:54

docs(dem): ogc-wcs add examples per-version

eba1ae0

docs(dem): note default interpolation method

a71cce3

docs(dem): remove subset from un-recommended parameter list

fd67712

vitaligi requested changes Feb 22, 2026

View reviewed changes

docs(dem): add download guide

3fa291b

shimoncohen requested review from asafmas-rnd and vitaligi February 23, 2026 09:16

asafmas-rnd requested changes Feb 23, 2026

View reviewed changes

Comment thread docs/MapColonies/DEM/Services/catalog/profile_v2_0.md

Comment thread docs/MapColonies/DEM/Guides/height_extraction.md

Comment thread docs/MapColonies/DEM/Services/download/README.md

shimoncohen requested a review from asafmas-rnd February 23, 2026 14:21

docs(dem): change download example to be for specific layer

e1cb1c1

asafmas-rnd previously approved these changes Feb 24, 2026

View reviewed changes

vitaligi requested changes Feb 24, 2026

View reviewed changes

Comment thread docs/ogc/protocols/ogc-wcs.md Outdated

Comment thread docs/MapColonies/DEM/Guides/height_extraction.md Outdated

Comment thread docs/ogc/protocols/ogc-wcs.md Outdated

Comment thread docs/ogc/protocols/ogc-wcs.md Outdated

vitaligi requested changes Feb 24, 2026

View reviewed changes

Comment thread docs/ogc/protocols/ogc-wcs.md Outdated

Comment thread docs/ogc/protocols/ogc-wcs.md Outdated

docs(dem): fix PR comments

c26d4e1

shimoncohen dismissed asafmas-rnd’s stale review via c26d4e1 June 4, 2026 15:15

shimoncohen requested a review from vitaligi June 4, 2026 15:15

shimoncohen requested a review from asafmas-rnd June 4, 2026 15:16

shimoncohen added 2 commits June 4, 2026 18:40

docs(dem): add new catalog fields

a32650b

docs(dem): add new catalog fields to other documents

e53a8be

asafmas-rnd requested changes Jun 8, 2026

View reviewed changes

vitaligi reviewed Jun 10, 2026

View reviewed changes

shimoncohen added 8 commits July 6, 2026 16:15

docs(dem): fix terrain provider doc

953256d

docs(3d): reference DEM terrain provider guide

2432a25

docs(dem): fix noDataValue in catalog v2 to be double

65ea3ae

docs(dem): update height extraction warning

e237b4f

docs(dem): update terrain provider guide

e87c17f

docs(dem): move warning placing in height extraction

4be5b13

chore: remove space at EOL

7c074b4

docs(dem): fix verticalSrsId row in catalog v2

d9ac59b

shimoncohen requested review from asafmas-rnd and vitaligi July 6, 2026 14:21

shimoncohen and others added 4 commits July 6, 2026 17:26

chore: replace product name

c1b8bba

Merge branch 'master' into new-dem

78ccb64

docs(dem): change warning in height exrtaction

d014d91

fix: broken merge

0106d3d

vitaligi requested changes Jul 8, 2026

View reviewed changes

Comment thread docs/MapColonies/DEM/Services/catalog/profile_v2_0.md Outdated

Comment thread docs/MapColonies/DEM/Services/catalog/profile_v2_0.md Outdated

Comment thread docs/MapColonies/DEM/Services/catalog/profile_v2_0.md Outdated

docs(dem): fix some information in v2 catalog profile

8c26748

vitaligi requested changes Jul 12, 2026

View reviewed changes

asafmas-rnd requested changes Jul 13, 2026

View reviewed changes

shimoncohen mentioned this pull request Sep 24, 2026

chore: add review-docs and generate-docs Claude Code skills #171

Open

shimoncohen commented Sep 24, 2026

View reviewed changes

		@@ -42,7 +42,7 @@ flowchart LR

		Query 3D CSW catalog service to find item(s) according to desired filter [example are here](/docs/ogc/protocols/ogc-csw/ogc-csw-examples)


		:::warning

		Currently the terrain provider is only available through the `3D catalog`.

Conversation

shimoncohen commented Feb 17, 2026

Uh oh!

github-actions Bot commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2026-09-28 11:35 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vitaligi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shimoncohen Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

github-actions Bot commented Feb 17, 2026 •

edited

Loading

Built to branch `gh-pages` at 2026-09-28 11:35 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

vitaligi left a comment •

edited

Loading

shimoncohen Jul 20, 2026 •

edited

Loading