ci: fail eslint job on lint errors - #58
Open
shimoncohen wants to merge 1 commit into
Open
shimoncohen wants to merge 1 commit into
shimoncohen wants to merge 1 commit into
Conversation
lint-action defaults to continue_on_error: true, and without checks: write its ESLint check run is rejected with 403, so lint errors never surfaced. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
shimoncohen
force-pushed
the
ci/enforce-lint
branch
from
September 28, 2026 11:45
633ee26 to
d4aa14f
Compare
shimoncohen
marked this pull request as ready for review
September 28, 2026 11:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Run eslintjob passes regardless of lint errors:wearerequired/lint-actiondefaults tocontinue_on_error: true, so errors don't fail the step.checks: write, so creating them fails with 403 (Resource not accessible by integration) and the failing ESLint check never appears.Example: #52 at
9ad9fbf— log showsESLint found 8 errors and 13 warnings (failure), job green.Changes in
.github/workflows/pull_request.yaml: addchecks: write, setcontinue_on_error: false.Impact
masterhas 0 lint errors (28 warnings, per chore(master): release 3.0.4 #56 CI), so this doesn't break current PRs; warnings still pass.checks: writehas no effect on fork PRs (read-only token there).🤖 Generated with Claude Code