Skip to content

Reword the done message #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vqsierra merged 1 commit into from
Nov 14, 2026
Merged

Reword the done message #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webapp/src/components/VotingBoard.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ export default function VotingBoard({ boardId }) {
{done && !closed && (
<div role="status" className="voting-board__error">
<Banner mode="success" withIcon>
Thanks, your votes are in.{' '}
Thank you! Your votes are in.{' '}
<Button inline onClick={() => handleDone(false)} disabled={pending}>Keep voting</Button>
</Banner>
</div>
Expand Down
4 changes: 2 additions & 2 deletions webapp/src/components/VotingBoard.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,13 @@ describe('VotingBoard', () => {

fireEvent.click(screen.getByText("I'm done voting"));

expect(await screen.findByText(/Thanks, your votes are in/)).toBeInTheDocument();
expect(await screen.findByText(/Thank you! Your votes are in/)).toBeInTheDocument();
expect(voteButton).toBeDisabled();
expect(screen.queryByText("I'm done voting")).not.toBeInTheDocument();

fireEvent.click(screen.getByText('Keep voting'));

await waitFor(() => expect(screen.queryByText(/Thanks, your votes are in/)).not.toBeInTheDocument());
await waitFor(() => expect(screen.queryByText(/Thank you! Your votes are in/)).not.toBeInTheDocument());
expect(voteButton).not.toBeDisabled();
expect(screen.getByText("I'm done voting")).toBeInTheDocument();
});
Expand Down
Loading