Repository navigation
Add "I'm done voting" and mvote status - #20
Merged
Merged
Conversation
- Web app: an "I'm done voting" button locks that participant's voting with a thank-you and a "Keep voting" link to undo it. The closed notice now reads "Voting has ended. The counts below are final." - firestore.rules: a participant may change only their own done flag (true or false); votes and extra dots are refused while done. - CLI: mvote status prints how many participants joined, how many are done, and how many dots are placed. - Tests: web app, CLI and emulator tests for the done flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets participants tell the facilitator they've finished, and lets the facilitator see it.
mvote status --board-id <id>prints, for example,Board 'b1' is open: 9 of 13 participants done, 142 dots placed.doneflag, to true or false. Spending dots and extra dots are refused whiledoneis true.Tests: web app 19 and CLI 33 pass locally, along with the UI check. The rules emulator tests, now 17, run in the Firestore rules workflow. I also checked the done, Keep voting and lock behavior by hand at phone size in the local demo.
Deploy order: the new rules still accept every write the current live app makes, so deploy the rules first (
firebase deploy --only firestore:rules), then merge. Merging deploys the web app through Workers Builds.