Repository navigation
Check the saved key file before publishing - #19
Merged
Merged
Conversation
The publish steps now ask the researcher to open the key file they saved. session-client 0.2.0's verifySessionFile confirms it opens this session's responses and matches the session in memory. Publishing waits for that check and the second copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to @malverdesoftware/session-client 0.2.0 (published with provenance) and adds a step to the publish flow. After downloading the key file, the researcher opens the copy they saved.
verifySessionFileconfirms it opens this session's definition and responses and matches the session in memory. Publish stays disabled until that check passes and the second copy is confirmed. The check runs locally; nothing is sent.It catches a damaged, wrong or outdated key file while the session can still be prepared again. It can't check passcodes, which only the relay can verify.
Checks:
npm run verify(environment, UI check, lint, 22 tests, typecheck, build, build check) andnpm run test:consoleagainst a local console all pass. The smoke test now goes through the new step.