Repository navigation
Remove duplicated checks and constants across the packages - #9
Merged
Merged
Conversation
No behavior, wire-format or public API change. - sealed-envelope: one P-256 constant in util.ts - relay: one admin-key check (asAdmin and DELETE) and one write-refusal check (draft and submission) - session-client: shared ID, secret and app patterns; one bad-link failure; one mapping from a network error to a saved-on-device result - ui: one definition of the touch button size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A code-review pass over the four packages. No behavior, wire-format or public API change, and no version bump.
util.tsinstead of one each inkeys.tsandenvelope.ts.asAdminandDELETE /sessions/:id; one refusal check (already submitted, session closed) shared by the draft and submission routes.patterns.ts; one bad-link failure instead of four copies of its message; one mapping from a network error to a saved-on-device result.Checked locally on Node 24:
npm test(all four packages),npm run typecheck,npm run build,node scripts/check-release.mjs, and the envelope fixture check.