Repository navigation
fix: bound memory when printing scans - #106
Merged
Merged
Conversation
Majkey25
marked this pull request as ready for review
November 5, 2026 18:03
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-page printing retained all decoded bitmaps in Android's PDF writer until the document closed. Stream one sampled JPEG at a time through the existing PDF writer while preserving paper size, margins, page selection, and metadata stripping.
On Huawei YAL-L21 (Android 10), the median sampled native-heap peak across three 20-page runs fell from 82.08 to 12.68 MiB. Seven device tests passed, covering PDF rendering and export, selected pages, margins, source metadata removal, cancellation, and output failure.
Claude Opus 5.5 and GPT-6 Astra independently reviewed the final code and found no confirmed release blockers. Play Console has insufficient app-level memory data to attribute the account alert or verify it cleared. A physical printer was not tested.