Repository navigation
Restore memtailor discovery fallback for older installations - #30
Merged
Merged
Conversation
Signed-off-by: Dima Pasechnik <dima@pasechnik.info>
Signed-off-by: Dima Pasechnik <dima@pasechnik.info>
Author
|
@d-torrance - as requested |
Signed-off-by: Dima Pasechnik <dima@pasechnik.info>
3 tasks done
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep header and library discovery as a fallback when an existing memtailor installation has neither CMake package config nor pkg-config metadata. This follows the review request on mathicgb PR #84 and preserves compatibility with older Homebrew packages.
The CMake config and pkg-config paths still take priority. The fallback creates the same
memtailor::memtailortarget expected by mathic and its installed CMake package.macOS CMake CI now uses the Homebrew memtailor package directly instead of building another copy from source. The Homebrew prefix is supplied to CMake for discovery. Installed pkg-config flag checks run when
memtailor.pcis available; the installed CMake consumer is tested on both platforms.Validation
Configured with
CMAKE_DISABLE_FIND_PACKAGE_memtailor=ONandCMAKE_DISABLE_FIND_PACKAGE_PkgConfig=ON, then built the sharedmathiclibrary against the installed memtailor headers and library on Gentoo.