Repository navigation
Install a consumable CMake package with ABI-aware dependencies - #29
Merged
Merged
Conversation
Export mathic::mathic with C++17, install versioned shared/static libraries and pkg-config metadata, and preserve the installed Debug ABI. Support both config and pkg-config dependencies and exercise relocated consumers in CI. Co-authored-by: Codex <noreply@openai.com>
Build tagged Autotools dependencies in a temporary prefix because current Homebrew CMake bottles omit package metadata. Co-authored-by: Codex <noreply@openai.com>
dimpase
commented
Sep 19, 2026
dimpase
left a comment
Author
There was a problem hiding this comment.
This can be simplified a bit once a new release of memtailor, 1.5+, is done (and propagated to upstreams such as Homebrew)
@d-torrance - over to you
dimpase
marked this pull request as ready for review
September 19, 2026 18:49
d-torrance
approved these changes
Sep 19, 2026
d-torrance
left a comment
Member
There was a problem hiding this comment.
Thanks!
I'll likely do new memtailor/mathic/mathicgb releases pretty soon. Definitely before the next M2 release in November
3 tasks done
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake installations currently provide no package config or exported target, hard-code installation directories, and reconstruct memtailor as a static imported library without its ABI flags. A Debug mathic build also forces
MEMT_DEBUGeven if the installed dependency has the Release layout.Install
mathicConfig.cmake, version metadata,mathic::mathic, andmathic.pc, using GNUInstallDirs and the existing Autotools-compatible SONAME. The target supplies C++17 and transitive dependency requirements. Prefer memtailor's CMake config, with pkg-config support for existing distribution packages, so this PR does not require Macaulay2/memtailor#23 to merge first. Dependency discovery now requires one of those metadata formats rather than assuming ABI compatibility from headers and a library alone.Publish the installed library's
MATHIC_DEBUGsetting independently of the consumer's build type, and inherit memtailor's own ABI flags. Enable CTest at the project root. Linux/macOS CI gains shared/static × Release/Debug installation checks, pkg-config flag checks, and separate Release consumers of relocated installations. The consumer requests C++11 to verify that the exported target raises the requirement to C++17. Include the new templates and fixtures in Autotools distributions, and document installation and consumption. CMake 3.18 is now required for aliases of non-global imported dependency targets.macOS CMake CI builds released dependencies with Autotools to obtain their pkg-config metadata, which the current Homebrew memtailor bottle lacks. This does not require unmerged dependency changes.
Local Gentoo validation, at low priority with two compilation jobs:
make distsucceeded and its archive contains the new CMake templates and consumer fixtures.This is the upstream counterpart of the CMake packaging work for the local Gentoo mathic ebuild. External mathic selection in M2 remains a separate task.
🤖 gpt-6-astra worked on this 🤖