Skip to content

Reject singular RR and CC matrices in inverse #4769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diracdeltafunk wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Reject singular RR and CC matrices in inverse #4769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions M2/Macaulay2/e/basic-mutable-matrices/dmat-lu.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,8 +537,7 @@ bool DMatLinAlg<RingType>::inverse(Mat& X)
for (size_t i = 0; i < LU.numRows(); i++)
ring().set_from_long(id.entry(i, i), 1);

solve(id, X);
return true;
return solve(id, X);
}

template <class RingType>
Expand Down
3 changes: 3 additions & 0 deletions M2/Macaulay2/tests/normal/inverse.m2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ assert try x^-1 else true
F = matrix {{1.,2,3},{4,6,9},{2,4,8}}
F * F^-1 == 1.

assert(try (inverse matrix{{1., 2.}, {2., 4.}}; false) else true)
assert(try (inverse matrix{{ii, 2*ii}, {2*ii, 4*ii}}; false) else true)

--- bug found in inverse, originally noticed in a Schubert2 computation.
--- this is from github issue #2051 (May 2021)
kk = ZZ/32003
Expand Down
Loading