chore: upgrade to bootstrap 5#808
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's frontend by upgrading to Bootstrap 5.3.8. The changes focus on improving maintainability and styling consistency by moving away from implicit SCSS Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request upgrades the project's styling from Bootstrap 4 to Bootstrap 5.3.8, introduces a dark mode theme, and updates various Blazor components to use modern utility classes. The code review identified several actionable improvements: adding type="button" to a Cancel button in ModalObjectSelection.razor to prevent accidental form submissions, correcting an excessively large margin class (me-5 instead of me-1) in EditConfigGrid.razor, adding @onclick:stopPropagation to nested <details> elements inside labels to prevent event bubbling, and replacing standard HTML onclick attributes with Blazor's @onclick directive in PasswordHashField.razor.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
Upgrades Bootstrap 4.6.1 → 5.3.8 and refactors CSS/SCSS layer to remove bare-element
@extendof Bootstrap classes, replacing them with explicit classes in Razor markup. Hardcoded color values are replaced with CSS custom properties.Most of the diff is related to replacing the library, not actual code changes.
Changes
bootstrap-4.6.1/forbootstrap-5.3.8/in shared styles; rebuiltshared.css@extend— SCSS no longer uses@extend .btn,@extend .table,@extend .form-control,@extend .btn-sm, or@extendof utility classes on bare elements (button,table,form input,th input,tbody button). These are now applied as explicitclass="..."attributes in Razor markuptableCSS reset for QuickGrid — the oldtable { @extend .table; }rule was removed; QuickGrid tables instead use explicit.tableclasses where needed and.quickgrid-scoped styles for padding and zebra stripingselect/buttonextends — SCSS no longer forces Bootstrap form-control/btn classes on every<select>or<button>; each component declares its own classes<table>,<button>,<input>,<select>elements throughout the admin panel, map, shared components, and forms now carry explicitclass="..."attributes#0366d6,#ff0,#f7f7f7,#d6d5d5,#0087ff,#dc3545, etc.) replaced with--omu-*variables or Bootstrap CSS variables (var(--bs-*))theme.css→Theme.scss— converted the existing plain-CSS theme file into a SCSS module. All--omu-*design tokens are now driven by SCSS maps ($omu-light,$omu-dark) and emitted via a@mixin omu-theme-varsunder:root/[data-theme="dark"].form-selectdropdown arrow uses a light-colored SVG via--bs-form-select-bg-imgoverride;form-control::placeholdercolor set explicitly; sidebarnav-linkcolor overridden to prevent[data-theme="dark"] a:not(.btn)from forcing blue on sidebar linksmdboundary (768px / 767.98px)Map.scssdeleted (.livemapgrid overridden by scopedMap.razor.css); unused Bootstrap variable overrides,lds-rollerspinner, duplicate#blazor-error-ui, commented-out rules removed fromCommon.scss,Main.scss@onclick(no Bootstrap JS); dropdown uses defaultdisplay: nonewith.show→display: block; position: relative; width: 100%; caret rotates via::aftertransition. Responsive breakpoint for sidebar collapse aligned to768px