Repository navigation
Drop the imported rank from monster field gear so it rolls its rarity - #68
Merged
Merged
Conversation
Retail gives a dropped item with no fixed rank a rarity rolled from globalEquipmentRankProbability.xml, by the killer's npc rank and level. The itemwebfinder import in #43 set rank="3" on 572 items of the monster gear groups 1 and 2 of globalDropItemSet, which had no rank in the retail data, so they always dropped at rarity 3 and never rolled. This restores those 572 files to their pre-import bytes. The import's ranks on other items stay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedToo many files! This PR contains 572 files, which is 472 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The itemwebfinder import in #43 set
rank="3"on 572 items that had no rank in the retail data. All of them are gear in the monster gear groups 1 and 2 ofglobalDropItemSet_Final.xml. Retail rolls the rarity of such a drop fromglobalEquipmentRankProbability.xml, by the killer's npc rank and level. A fixed rank skips that roll, so these items always drop at rarity 3. This restores the 572 files to their exact pre-import bytes.Xml/item/1/:rank="3"removed from<property>. No other line changes, and no later commit had touched these files.Why the fixed rank is wrong here
CItemOptionTable0x1405f4d30 in MS2Recomp, returns an item's fixedrankbefore it reads the table.rank="2"in retail, and every one of their sniffed drops was Rare.Server side: MS2Community/Maple2.File#94 parses the table and reads a missing rank as 0. PrivateMaple2 rolls the rarity on the
global-equipment-rank-probabilitybranch.Verification
71a489e0e~1byte for byte.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.