Repository navigation
Make the Rising Kick tooltip say 3 hits at every level - #65
AngeloTadeucci wants to merge 1 commit into
Conversation
Skill 11000031 has three single-hit attack points in all 48 level blocks, but its description says 7 hits from level 2 to 12. The typo is in the Korean source and was carried into every locale. Fixed in the Weblate JSON for en, ko, cn and jp, and directly in the de and pt XML, which have no Weblate source for this file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update localized hit counts WeblateConverter/Json/{cn,en,jp,ko}/stringskilldescription.json, Xml/string/{cn,de,en,jp,kr,pt}/korskilldescription_100.xml |
Descriptions for levels 2–12 change the hit count from seven to three. This includes the listed Striker and CharacterBalance descriptions. Damage percentages and other description text remain unchanged. Chinese XML descriptions for levels 3–11 also gain a trailing newline. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix · Severity of issue fixed: Low
Suggested reviewers: zintixx
Merge Risk: 
da70f
-
The localized tooltip text update is ready to merge with normal checks.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly identifies the main change: updating the Rising Kick tooltip from 7 hits to 3 hits. It is concise and specific, although “every level” slightly overstates the change because level 1 … Linked Issues check Issue #1570requires the Rising Kick tooltip to show 3 hits instead of 7. The pull request changes skill 11000031 levels 2–12 from 7 to 3 in the Weblate JSON sources and the locale XML outputs. The di…Out of Scope Changes check The changes are limited to Rising Kick skill 11000031 tooltip strings in the listed locale source and XML files. Regenerated XML files and direct edits for locales without Weblate sources support the … Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Full details: Title check
-
Explanation
The title clearly identifies the main change: updating the Rising Kick tooltip from 7 hits to 3 hits. It is concise and specific, although “every level” slightly overstates the change because level 1 remains unchanged.
Full details: Linked Issues check
-
Explanation
Issue
#1570requires the Rising Kick tooltip to show 3 hits instead of 7. The pull request changes skill 11000031 levels 2–12 from 7 to 3 in the Weblate JSON sources and the locale XML outputs. The diff preserves the damage percentages and does not change skill 11000032. The reportedjson-to-xml-allandverify-allchecks pass.
Full details: Out of Scope Changes check
-
Explanation
The changes are limited to Rising Kick skill 11000031 tooltip strings in the listed locale source and XML files. Regenerated XML files and direct edits for locales without Weblate sources support the linked issue. The diff does not show unrelated skill or functional changes.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (10 skipped: 10 unsupported.)
-
Finishing Touches
-
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Rising Kick, skill 11000031, hits 3 times at every level, but its tooltip says 7 hits from level 2 to 12. Nexon's Korean source has the typo and every locale copied it. Nexon fixed it later in
kr_latest, which says 3회. This changes the hit count from 7 to 3 on every affected line and leaves the damage percentages as they are.WeblateConverter/Json/{en,ko,cn,jp}/stringskilldescription.json: levels 2 to 12 of 11000031, in both theStrikerandCharacterBalance_Striker_01variants where a locale has them. These are the Weblate sources, so the nightly regen carries the fix.Xml/string/{cn,en,jp,kr}/korskilldescription_100.xml: regenerated from that JSON withjson-to-xml-all.Xml/string/{de,pt}/korskilldescription_100.xml: edited directly. They have the same typo and no Weblate source for this file, so the regen leaves them alone.Verification
Xml/skill/11/11000031.xmlhas 48 level blocks, 12 levels times 4 feature variants. Each has three attack points withdamageProperty count="1", so 3 hits is right everywhere.mainby that one character, and no line outside id 11000031 changed.json-to-xml-allfollowed byverify-allpasses. Running the regen a second time on top of the change leaves the diff byte-identical, so the nightly won't revert thedeandptedits.Not checked: the tooltip in a client. Weblate may also flag the en, cn and jp rows as needing edits, because their ko source string changed. The first Weblate sync after merge shows whether it does.
Fixes MS2Community/PrivateMaple2#1570
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit