Add GitHub Actions workflow for staging and Production#62
Open
adamshire123 wants to merge 1 commit into
Open
Conversation
production builds of NDE customization package Why these changes are being introduced: We want to automate the build process for the NDE customization package to help streamline the testing and deployment workflows for staging and production views. Additionally, we want to follow existing conventions for dev, stage, and prod builds so other engineers are familiar with the workflow structure and can easily find the relevant build artifacts. How this addresses that need: - Adds a Github Actions workflow that triggers on pushes to the mit-main branch for staging builds, resulting in a zip file for uploading to our NDE_STAGE view. - Adds a GitHub Actions workflow that triggers on release publication for production builds resulting in a zip file for uploading to our NDE view - renames the existing build workflow to dev-build to clarify its purpose and avoid confusion with the new stage and prod workflows. Side effects of this change: None Relevant ticket(s): https://mitlibraries.atlassian.net/browse/NDE-95
There was a problem hiding this comment.
Pull request overview
This PR introduces GitHub Actions workflows to produce build artifacts (ZIPs) for staging and production deployments of the NDE customization package, and clarifies the existing developer build workflow.
Changes:
- Added a staging build workflow triggered on pushes to
mit-main(and manual dispatch). - Added a production build workflow triggered on release publication (and manual dispatch).
- Added/renamed a development build workflow that accepts a
view_idinput for ad-hoc builds.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/stage-build.yml |
New workflow to build with VIEW_ID=NDE_STAGE and upload the resulting artifact. |
.github/workflows/prod-build.yml |
New workflow to build with VIEW_ID=NDE on releases and upload the resulting artifact. |
.github/workflows/dev-build.yml |
Workflow-dispatch build that accepts a view_id and uploads the corresponding artifact. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+39
to
+47
| - name: Upload NDE customization package | ||
| # postbuild.js produces dist/01MIT_INST-<view_id>.zip alongside the unzipped folder. | ||
| # archive: false uploads that file as-is without re-zipping it; the artifact name is | ||
| # taken from the filename. | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| path: dist/01MIT_INST-NDE_STAGE.zip | ||
| archive: false | ||
| if-no-files-found: error No newline at end of file |
Comment on lines
+38
to
+46
| - name: Upload NDE customization package | ||
| # postbuild.js produces dist/01MIT_INST-<view_id>.zip alongside the unzipped folder. | ||
| # archive: false uploads that file as-is without re-zipping it; the artifact name is | ||
| # taken from the filename. | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| path: dist/01MIT_INST-NDE.zip | ||
| archive: false | ||
| if-no-files-found: error No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
We want to automate the build process for the NDE customization package to help streamline the testing and deployment workflows for staging and production views.
Additionally, we want to follow existing conventions for dev, stage, and prod builds so other engineers are familiar with the workflow structure and can easily find the relevant build artifacts.
How this addresses that need:
Side effects of this change:
None
Relevant ticket(s):
https://mitlibraries.atlassian.net/browse/NDE-95