Repository navigation
Read TF from any bag topic (--tf-topic / --tf-static-topic) - #24
Merged
Merged
Conversation
Add --tf-topic and --tf-static-topic (defaults /tf and /tf_static) so bags that record TF on namespaced topics like /<robot>/tf still go through frame filtering. The filtered transforms are republished on /tf and /tf_static as before.
Add --tf-static-topic (default /tf_static) so bags that record static TF on a namespaced topic like /<robot>/tf_static can be dumped too, matching the option on the play_rosbag TF plugin.
harelb
force-pushed
the
feature/bag-tf-topic
branch
from
October 21, 2026 19:46
7e56a63 to
89e02cb
Compare
harelb
marked this pull request as ready for review
October 21, 2026 19:49
nathanhhughes
approved these changes
Oct 22, 2026
nathanhhughes
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! I'm definitely fine with this even if we don't end up recording remapped TF topics long term.
The option descriptions are a little off though; I don't need the examples of alternative /tf and /tf_static topics, and technically the /tf_static processing publishes aggregated transforms, not filtered transforms. I forget if you have merge access, so lmk if you have time to clean them up or just want me to merge this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bags that record TF on namespaced topics (e.g.
/<robot>/tf,/<robot>/tf_static) used to skipTF frame filtering, because the TF plugin and
static_tfs_from_bagonly looked at/tfand/tf_staticby name. Remapping the topic at playback doesn't help: the plugin decides what tofilter from the topic names stored in the bag.
play_rosbagTF plugin: add--tf-topicand--tf-static-topic(defaults/tf,/tf_static). The chosen bag topics go through the same--filter-tf/-k/-ffiltering,and the filtered transforms are still republished on
/tfand/tf_static.static_tfs_from_bag: add--tf-static-topic(default/tf_static).The defaults keep existing commands and older bags behaving exactly as before.
Testing
/tf) throughplay_rosbag --filter-tfwith the defaults; framefiltering and a downstream Hydra scene graph worked as before.
static_tfs_from_bagon the same bag with the default topic extracted all 17 static transforms.🤖 Generated with Claude Code