Repository navigation
Build: sign the release APK with a permanent key - #7
Merged
Merged
Conversation
android/app/build.gradle.kts reads the release signing config from the properties file named by AUDIOBRIDGE_KEYSTORE_PROPS (unsigned release without it). CI builds and uploads the signed AudioBridge.apk on pushes to main and workflow_dispatch; PRs still build the debug APK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
android/app/build.gradle.kts:releasesigning config from the properties file named byAUDIOBRIDGE_KEYSTORE_PROPS(storeFile, storePassword, keyAlias, keyPassword); without the variable the release APK is built unsigned, debug is unchanged.androidjob: pushes tomainandworkflow_dispatchbuild:app:assembleReleaseand upload the signedAudioBridge.apkartifact; PRs still build/upload the debug APK.~/.config/audiobridge/); moving from the debug-signed APK needs one reinstall.Checked locally:
:app:assembleReleasewith the key →apksigner verify --print-certsOK (cert SHA-2561b85a9dbc80f5f02431512286a29f94b9682193151cb60775cba27362937dbc0); without the variable →app-release-unsigned.apk, build succeeds.