Repository navigation
Build: cargo-ndk 4.x and NDK r30 - #6
Merged
Merged
Conversation
cargo-ndk 4 no longer reads [package.metadata.ndk], so the platform fell back to API 21 and linking failed on -laaudio. Pass --platform 26 explicitly (Gradle buildRustLib, CI clippy) and drop the dead metadata. Gradle now copies only libaudiobridge.so into jniLibs: cargo-ndk 4 -o also copies iroh's own cdylibs. Toolchain moves from NDK r23 to r30 (30.0.16248370).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[package.metadata.ndk], so the platform fell back to API 21 and linking failed with-laaudio(e.g. the Android APK job on main after CI: self-hosted runner #5). Pass--platform 26explicitly in the GradlebuildRustLibtask and in the CI Android clippy step; drop the dead metadata.cargo ndk -oin 4.x copies every cdylib artifact, including iroh/iroh-relay own cdylibs, into jniLibs.buildRustLibnow builds without-oand copies onlylibaudiobridge.so(and drops stale files fromjniLibs/arm64-v8a).30.0.16248370); the self-hosted runner already uses it. Docs (AGENTS.md, READMEs, CI comment) updated.Verified on the server:
./gradlew :app:assembleDebugwith cargo-ndk 4.1.2 + NDK r30;libaudiobridge.soNEEDED = liblog, libaaudio, libdl, libm, libc; all undefined symbols resolve against the API 26 stubs except weakgetrandom.