Repository navigation
Remote control from both sides (0.3.0) - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PROTOCOL_VERSION = 2): both sides report their controls (PcControls: audio, mic, mic_default, playback volume;PhoneControls: mic switch, mic_ready, media volume) and can request changes (SetPc/SetPhone). Core only forwards requests; the apps apply them. Control streams are read through a channel soselect!never drops half a frame. An old-version Hello is rejected with a readable reason.Breaking
Protocol v2: PC and phone must both be updated.
Verification
cargo clippy --workspace --all-targets -D warnings+cargo ndk -t arm64-v8a clippy -p audiobridge-android: cleancargo test --workspace: all pass, incl. newremote_control_in_both_directionsintegration test