Repository navigation
Read one gas's fit where only its fit is needed - #8
Merged
Merged
Conversation
electronic_static_polarizability (and so ionisation_parameters and the ionisation rates) and the compact models looked a parent fit up in fitted_models(), which builds all fifteen fits with their Kramers-Kronig absorption terms. They now use fitted_model(name). The entry-point test also checks that the full set of fits is never built. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Documentation build overview
84 files changed ·
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7, found while measuring solprop's start-up. No value changes.
Three callers looked a parent fit up with
fitted_models()[name], which builds all fifteen gas fits, each with its Kramers–Kronig absorption term:gas.ionisation.electronic_static_polarizability, and through itionisation_parametersand the ionisation rates;They now use
fitted_model(name), added in 0.9.0, which reads one record.ionisation_parameters("He")goes from 1.73 s to 0.88 s on the Mac. The entry-point test intests/test_catalogue.pynow also checks that the full set of fits is never built, and callsmolecular_rate_model.The full
poe checkpassed locally: 21,507 tests with 1 skipped, 100% coverage, docs built.🤖 Generated with Claude Code