Repository navigation
Revert modified noise - #461
Merged
Merged
Conversation
The modified shot-noise model (a constant noise field added inside the nonlinear operator, excluded from dispersion) does not give the correct physics, so this reverts the model of LupoLab#414 (squash commit 9e9a270): `shotnoise` is a Bool again and `true` adds one-photon-per-mode noise to the input field, as before LupoLab#414. Kept from LupoLab#414, because they are not part of the noise model: - the QueueExec fix in Scans.jl (a worker no longer recreates a finished scan's queue file), - the .gitignore entries, - the approximate comparison of the cached PPT rate in test_ionisation.jl, - the `rng` keyword of prop_capillary/prop_gnlse, now passed to Fields.ShotNoise(rng) for seeded input noise (new test in test_interface). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WM2AxPkj1PCFvBcaaaanzV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the modified noise model again.