Repository navigation
feat(shipyard): audit robust recovery across immutable scenarios - #2725
Draft
Tristan-Stoltz-ERC wants to merge 13 commits into
Draft
Tristan-Stoltz-ERC wants to merge 13 commits into
Tristan-Stoltz-ERC wants to merge 13 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a separate finite-scenario robustness auditor on top of the tiny exact-polygon and placement work. It is an audit layer, not another optimizer, and does not modify the existing production verifier.
Paradigm shift: robust plans are checked over immutable scenario sets
The caller supplies ground-truth scenario definitions separately from candidate plans. A robust acceptance requires the scenario and plan IDs to match exactly, every required block/reservation/operation/resource-use identity to remain present, mandatory occupancy not to be shortened, modeled operation durations to stay fixed, declared finish-to-start precedence to hold, spatial reservations not to conflict in overlapping time, unary resource reservations not to overlap, and resource uses not to overlap source-declared outages.
Candidate plans cannot change outage windows. Omitting a scenario or mandatory work produces
Incomplete; a complete scenario with a genuine spatial/resource/precedence conflict producesNotRobust; only a complete, conflict-free finite scenario set receivesRobustlyFeasible. An empty scenario set is rejected rather than passing vacuously.Conformance coverage
Scope and limits
This V0 models static planar footprints over half-open integer-tick intervals and unary resource uses/outages. It does not model transfer trajectories, swept-volume clearance, crane kinematics, tandem lifts, capacity greater than one, setup/changeover, load charts, stacking/support, floor bearing or probabilistic scenario likelihoods. Passing covers only supplied finite scenarios and the declared model.
Verification status
The implementation and frozen authored tests are committed to the feature branch. No local Rust toolchain was available, so compilation and test success have not been claimed. The exact-head Rust 1.96 formatting, offline test and Clippy-with-warnings-denied workflows are the required gates; keep this PR draft until they pass.