docs(evm): fix chain-id hex, delegation cap, block.max_gas, TBDs, and formatting#179
Merged
Conversation
…matting Corrections surfaced while reviewing the EVM rollout/user guides: - rollout.md: correct EVM chain-id hex `0x494b329` -> `0x494c1a9` (hex(76857769); matches metamask guide, bugs.md, openrpc.json). - rollout.md: reconcile `block.max_gas`. `25,000,000` (ChainDefaultConsensusMaxGas) is the fresh-genesis default only; the in-place v1.20.0 upgrade does not change it (EnsurePresent preserves the existing value), so live mainnet/devnet run `-1`. Removes the conflict with migration.md. - main.md: `max_validator_delegations` default 2000 -> 2500 (DefaultMaxValidatorDelegations in x/evmigration/types/params.go). - tune-guide.md: replace bare TBD economic params with shipped code defaults (minimum_stake 0 ulume; base_action_fee 0.01 LUME / fee_per_kbyte 0.00001 LUME/kB; supernode_fee_share 2%/200 bps), keeping the "review for mainnet" action flags. - supernode-migration.md: add missing spaces around inline code/links (e.g. add`evm_key_name` -> add `evm_key_name`). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce00661bf0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The tune-guide row maps to x/action `SuperNodeFeeShare` (decimal, default `1.0` = 100% per x/action/v1/types/params.go), not the x/supernode `RegistrationFeeShareBps` (200 bps) used in the previous commit. Fix the value to `1.0` (100%) so operators tune the correct parameter. Also drop a stray blank line after a heading in rollout.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
a-ok123
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation-only corrections to the EVM integration guides, each verified against the code.
Changes
0x494b329→0x494c1a9hex(76857769); matches metamask-configuration.md, bugs.md, openrpc.jsonmax_validator_delegationscap said 2000main.mdDefaultMaxValidatorDelegations = 2500(x/evmigration/types/params.go:51)block.max_gasconflict (migration.md-1vs rollout.md25M)minimum_stake0 ulume;base_action_fee0.01 LUME /fee_per_kbyte0.00001 LUME/kB;supernode_fee_share200 bps (2%)On
block.max_gas(#3)ChainDefaultConsensusMaxGas = 25_000_000(config/evm.go) is applied only at fresh genesis init (lumerad init/testnet). The in-placev1.20.0upgrade'sEnsurePresentonly seeds consensus params when missing (else preserves the existing value), so it never overwrites an existing chain'smax_gas— livelumera-mainnet-1and the running EVM devnet run-1. migration.md's-1was correct; rollout.md's framing of25Mas the upgraded-mainnet value was the bug, now reconciled.Notes
🤖 Generated with Claude Code