Repository navigation
Stop deep-copying the scope on every recursive evaluation - #18
Merged
Merged
Conversation
- f() no longer copies c at all; leaf checks moved above it - Constants, Reduce's legacy form, and TrapezoidalIntegrate each copy c themselves before writing into it, matching _apply_fn's existing pattern - Add tests/test_scope_isolation.py covering leak and cross- contamination cases in both directions 2-3x faster on arithmetic- and Reduce-heavy expressions. No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
f() deep-copied its whole variable scope (c) on every single recursive evaluation step, even for leaf values. Only three constructs actually introduce new bindings - Constants, Reduce's legacy accumulator form, and TrapezoidalIntegrate - so only they need to copy, and only their own copy.
Measured 2-3x faster on arithmetic- and Reduce-heavy expressions. No behavior change. 765 tests pass (758 existing + 7 new), 1 skipped.