Repository navigation
Stage 3: split constructs into per-category topic files - #17
Merged
Merged
Conversation
- Move the 229 module-level construct/utility functions into 14 topic files by domain - Add _construct_shared.py for the 3 utilities called from more than one topic file - Add _exceptions.py for MathJSONException/MathJSONExpression, breaking a circular import - Keep If, the constructs dict, create_mathjson_solver, and extract_variables in __main__.py No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the 229 module-level construct/utility functions Stage 2 hoisted into main.py into 14 per-category topic files, plus two new leaf modules.
No behavior change. 758 tests pass, 1 skipped (unchanged). main.py goes from 3,602 to 1,191 lines.