Skip to content

chore(contracts): upgrade soroban-sdk 23 → 26 and align OpenZeppelin tags #35

Description

@Mackenzie-OO7

The workspace pins soroban-sdk = "23.0.2". The live Stellar network is on Protocol 28, so we are five protocol versions behind. The soroban-sdk major version tracks the protocol version, and majors are not cross-compatible.

Every contract in this wave is being rewritten. Upgrading first means contributors write against the target SDK once instead of twice, so this issue blocks all the others.

We are targeting SDK 26, not the latest 28, because we want OpenZeppelin's audited stellar-access (Ownable / AccessControl) and stellar-pausable (emergency pause) libraries — and OZ has no Protocol 28 release:

soroban-sdk
Live network 28
Latest SDK release 28.0.0
OZ stellar-contracts latest tag (v0.7.2) 26.1.0
OZ unreleased main 27.0.2
This repo today 23.0.2

A second problem: the OZ dependencies are already declared in the workspace Cargo.toml but no contract uses them, and they sit at two different tags — stellar-access and stellar-macros at v0.5.1, stellar-pausable, stellar-fungible and others at v0.3.0. That needs unifying before anything can depend on them.

Scope

  • Cargo.toml (workspace root) — bump soroban-sdk, unify every OZ dependency onto a single tag (v0.7.2 is the latest stable compatible with SDK 26)
  • contracts/*/Cargo.toml — all five pin soroban-sdk = "23.0.3" directly, bypassing the workspace declaration. Switch to soroban-sdk = { workspace = true } so there is one version to change in future
  • contracts/*/src/** — fix whatever breaks across plans, locked_in, target_savings, spend_save, mock_pool
  • rust-toolchain.toml — bump if SDK 26 needs newer than Rust 1.89.0

Spike — do this first, it can invalidate the whole approach

  1. Build any one contract against SDK 26
  2. Deploy it to testnet (which runs Protocol 28)
  3. Invoke a function and confirm it succeeds

If SDK-26 contracts cannot be deployed to or invoked on a Protocol-28 network, stop and comment on this issue. The agreed fallback is SDK 28 with hand-rolled admin/pause behind a small internal trait, so OZ can be swapped in when they ship 28.

Acceptance criteria

  • Spike completed and the result reported in a comment
  • soroban-sdk bumped to 26.x in the workspace Cargo.toml
  • All OZ dependencies on a single consistent tag
  • All five contracts/*/Cargo.toml inherit soroban-sdk via workspace = true
  • cargo test --workspace passes — 52 tests pass today, none should regress
  • cargo build --target wasm32v1-none --release succeeds for all five contracts
  • Each built .wasm is under the 128KB network limit
  • Cargo.lock committed

Out of scope

  • Do not modify anything in packages/. Those TypeScript bindings are generated against a deployed contract and are regenerated by a maintainer between phases.
  • Do not adopt the OZ libraries in contract code yet — separate issue. This one only makes them available and consistent.
  • Do not fix clippy warnings — separate issue.
  • Do not change contract logic. If a test only passes because you changed behaviour, comment instead.

Activity

  1. added
    enhancementNew feature or request
    help wantedExtra attention is needed
    contractsimprovements or additions to smart contracts
    on Sep 23, 2026
  2. Fi-zzy commented on Sep 23, 2026

    @Fi-zzy

    @Fi-zzy has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    I've reviewed the issue thoroughly and can start working on it right away. Looking forward to contributing.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Fi-zzy to this issue.

  3. drips-wave commented on Sep 26, 2026

    @drips-wave

    Congratulations, @Fi-zzy! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on September 30, 2026.

    🧑‍💻 @Fi-zzy: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  4. Fi-zzy commented on Sep 27, 2026

    @Fi-zzy

    @Mackenzie-OO7 Implemented issue #35 in PR #48. The workspace now uses Soroban SDK 26.1.x with Rust 1.91.0, all contract manifests inherit centralized SDK/XDR versions, OpenZeppelin dependencies are aligned to v0.7.2, and the protocol-26 test fixture is updated.

    Validation: all 57 workspace tests pass and all five WASM artifacts are below 128KB.

    PR: #48

  5. drips-wave commented on Oct 7, 2026

    @drips-wave

    This issue has been marked as completed by a Drips Wave moderator for @Fi-zzy as part of the Stellar Wave Program's 9th Wave 🥳

    Moderator's reason: [Auto-assessed] PR #48 is open with no maintainer objections or responses across any of the channels, and it cleanly addresses all aspects of issue #35 (upgrading soroban-sdk to 26.1.0, unifying OpenZeppelin dependencies to v0.7.2, migrating contract manifests to workspace inheritance, updating rust-toolchain to 1.91.0, and adjusting the protocol version in test fixtures).

    😎 @Fi-zzy: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

    ℹ️ Note: This issue was marked complete via moderation. Points were issued even though the GitHub issue remains open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programcontractsimprovements or additions to smart contractsenhancementNew feature or requesthelp wantedExtra attention is needed

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions