Skip to content

fix: localize mod settings and save existing profiles - #37

Open
zj1022 wants to merge 2 commits into
LocalExile:mainfrom
zj1022:fix/mod-settings-localization
Open

zj1022 wants to merge 2 commits into
LocalExile:mainfrom
zj1022:fix/mod-settings-localization

Conversation

@zj1022

@zj1022 zj1022 commented Nov 18, 2026 •

Copy link
Copy Markdown

Changes

  • Localize mod names, descriptions, settings labels, descriptions, units, option labels and validation messages through the existing English, Russian and Simplified Chinese catalogs on Windows and Linux. Persist canonical setting values and identifiers in every language.
  • Fix a Windows save error reproduced with Pet Loot settings written in game. Group controls had emitted both Enabled and enabled in the same profile. Preserve undeclared fields and write each declared field once using the schema name.

Localization was prompted by mingyue8621/Waypoint. It uses the shared settings editor and requires no LocalExile Mod API changes.

Verification

  • Built the Windows app with .NET 10.0.403, zero warnings and errors. Catalog parity and Windows adapter checks passed.
  • Opened Pet Loot in Simplified Chinese against a LocalExile test checkout. Reproduced the duplicate-key error, then saved the currency option with the fix. The resulting JSON parsed and retained the existing character speed of 3x. Searching for Pet Loot by either its English name or its translated Chinese name found the same installed entry. The final targeted Windows suite passed all 25 tests.
  • Added a regression for existing property casing and undeclared fields. Waypoint.Tests: 464 passed, two environment-dependent failures also reproduced on clean main (folder picker and Map Viewer fixtures). Launcher.Checks was blocked by a missing intermediate DLL on both the branch and clean main. The Linux solution also compiled with zero warnings or errors. Linux GUI and English/Russian UI were not exercised interactively.

Use the existing English, Russian and Simplified Chinese catalogs. Rebuild declared group fields from the current controls so saved profiles with case-insensitive property names round-trip without duplicate keys.

Fork reference: mingyue8621/Waypoint localization changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant