Repository navigation
fix: name the program on a server port, and let mod changes past it - #36
Merged
Merged
Conversation
A player could not tick a mod: Steam's helper was listening on 8080, the Patch server's port, and Waypoint refused every mod change with "Port 8080 is occupied by another process (PID 29304); Patch is not owned by this checkout." The servers were stopped, the message did not say which program it was, and the program held none of the mod files. - A port conflict now names the program holding the port: "Port 8080 is used by steamwebhelper.exe (PID 29304). Patch needs this port." (translated in Russian and Simplified Chinese). - The snapshot lists such a conflict in PortsInUse when the holder is no LocalExile server or watcher. It still blocks a start, but no longer a change of mods, modules, leagues or accounts (EditConflicts in the app, the same rule in the adapter). Another LocalExile's server on the port, or a holder Waypoint cannot name, still blocks everything. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
A player reported that ticking any mod failed with:
The servers were stopped. Their own port check found nothing because it filtered by process name. The program on 8080 turned out to be Steam's helper. Waypoint refused every mod change because any process it doesn't own on a server port counted as a conflict, even one that holds none of the mod files.
PortsInUsefield.RuntimeSnapshot.EditConflicts(all conflicts but those) now gates the Mods section, Install, Update, the Use check box and Accounts, on Windows and Linux. The adapter applies the same rule in the mod, content (modules, leagues) and account guards.SafeToLaunchand the adapter's start checks still use every conflict), since Patch cannot bind its port. Another LocalExile's server or watcher on the port, or a holder Waypoint cannot name, still blocks everything.Test-ServerProcessis the existing "foreign server or watcher" rule moved into a function, so both checks share it.Get-PortConflictbuilds the message.docs/launcher.md(Mods) anddocs/runtime-contract.md(ownership) are updated.Checks
dotnet build Waypoint.slnxandWaypoint.Linux.slnx: 0 warningsdotnet test Waypoint.slnx: 465 passedtests/Launcher.Checks: 212 passed (new:EditConflicts, and both messages translated in every language)tests/AccountData.Tests.py,tests/Capture.Tests.py,tools/missing-translations.py: cleanhttp.serverlistening on 127.0.0.1:8080:Inspectreported "Port 8080 is used by python.exe (PID 45644). Patch needs this port." in bothConflictsandPortsInUse, and no account block.WAYPOINT_HOME) ticked and unticked a mod on My Mods;mod-state.txtchanged and was restored.Not checked: the Play refusal in the running app (the click showed nothing and wrote nothing to the log; the button is most likely disabled; I did not push further, as a real start would run
live.ps1on that checkout), a release install, Linux at runtime.🤖 Generated with Claude Code