Repository navigation
feat: Steam clients on a source copy, and Game client as a chooser - #33
Merged
Merged
Conversation
…m the folder list A source copy updated past its client (LocalExile main runs 3.29.3c and 3.29.3d; the folder still held 3.29.3b) failed at Start servers with LocalExile's stack trace, and its user had no way to the Game client window: the link was only on a release's Play page, which Advanced mode leaves out. - Game client… is a row of the sidebar's folder list: one place, for a release and a source copy, in Simple and in Advanced mode. The Play page's standing link is gone; it shows there only when LocalExile refused the client in the last run. - The sidebar marks a client its LocalExile does not run (warning sign and colour in the box, "does not fit" on the list's row). - The Game client window says "does not fit this LocalExile" on such a client, names the versions LocalExile runs, and offers "Use another client…" when one that fits is on this PC: the move a Play would make, with nothing started after it. On a source copy the window lists the clients; it has no Steam download there yet (the adapter prepares only a standalone client) and no copy of a linked client. - Start servers on a source copy gets the client check Play has, since live.ps1 reads the game data from the client first. Not with Skip data check; after a Not now it goes on and does not ask again. - LocalExile's refusal is recognized in live.ps1's output (wrapped by PowerShell) and in a release launcher's error: the run's last line, Control's status line and the Play page say it in plain words. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…ooser A source copy could only use a standalone client: the adapter wanted Content.ggpk, so the Game client window had no Steam download there and the setup guide passed over a Steam install. LocalExile itself runs one from a checkout, and Waypoint now follows its rules. Adapter (scripts/RuntimeBridge.ps1) - The layout is told as LocalExile tells it: Content.ggpk first, else a Steam install's Bundles2\_.index.bin. Whether a checkout runs a Steam install is its own live.ps1's to say; one that does not keeps the old requirement and says so. - Prepare-Client prepares either layout by the steps of LocalExile's own guide: Game.exe from PathOfExile.exe or PathOfExileSteam.exe, the keys kept, the patched copy by the Auth tool (which makes a Steam install's copy read the loose files), and the login list by the Patch tool, in the archive or in the client folder. Core - ClientKind.Steam: a Steam install is a client to copy, known by its index. Epic, and Steam without its index, stay unusable. A client from Steam fits only a LocalExile that lists its index. - A copy puts the file a layout is known by last, so a checkout that has it has the whole client. - What Waypoint keeps beside Client in a checkout (Clients\, .waypoint-*) is named in the checkout's own info/exclude, so git does not list it and a switch of the checkout never stashes part of a client. Setup guide - Finds and takes a Steam-layout client, for a release and a source copy, and warns about Steam files that do not match their executable. Game client window - A source copy has the Steam download; what came in is prepared through the adapter. - The window is a chooser. Any line that is not the client in use has one button, "Use this client": a client the folder set aside is swapped in, and a client of another folder, or of a folder found with "Browse for a client…", is asked about first. The question names both folders, says what becomes of the client in use (a copy is kept, a link loses only the link) and gives the ways there are: a copy in every mode, and a link in Advanced mode only. Simple mode never links. - In Advanced mode "Make a copy…" also works on a source copy's link and on a link to another LocalExile's client, and a kept client can take a link's place. Texts are short, plain sentences, translated into Russian and Simplified Chinese; texts no longer used are out of the catalogs. docs/launcher.md and the README describe all of it. Checked: both solutions build without warnings; Waypoint.Tests 461, Launcher.Checks 208, every adapter test script, missing-translations clean. In the running app on a throwaway checkout with the real Steam 3.29.3d client: the guide copied and prepared it and built LocalExile, Play brought the client to its login screen, and the window's copy, link, kept-client and browse paths were run in Advanced and Simple mode. The Steam download itself was run with a stand-in for the download tool, not against Steam.
"Browse for a client…" had a margin of its own, which dropped the button style's bottom margin and set it a few pixels lower than "Download a version…". It now takes the style's margin, which also spaces the two.
Started from a PowerShell 7 terminal, Waypoint inherits that shell's PSModulePath, which names PowerShell 7's own module folders first. Windows PowerShell, which live.ps1 and the adapter run under, then cannot load its built-in modules: "Prepare client" stopped with "The term 'Get-FileHash' is not recognized". PowerShell 7 takes its own folders out when it starts Windows PowerShell itself, but not for a program in between. Waypoint now does the same for its own process at its start, so everything it starts gets a path Windows PowerShell can use: PowerShell 7's user folder, its shared folder and the Modules folder beside a pwsh go, and every other entry stays in its order. Seen in the running app, started from a PowerShell 7 shell on a stand-in source copy: before, Prepare client failed at Get-FileHash; after, it hashes the executables and goes on to the build. Three unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
A game client LocalExile refuses is caught (f41f6f4)
A source copy updated past its client failed at Start servers with LocalExile's stack trace, and its user had no way to the Game client window.
A Steam-layout client on a source copy (0bf01de)
Until now a source copy could only use a standalone client. LocalExile itself runs a Steam install from a checkout, and Waypoint now follows its rules.
Content.ggpkfirst, else a Steam install'sBundles2\_.index.bin).Prepare-Clientprepares either layout by the steps of LocalExile's own guide:Game.exefromPathOfExile.exeorPathOfExileSteam.exe, the keys kept, the patched copy, and the login list. Whether a checkout runs a Steam install is read from its ownlive.ps1; one that does not keeps the old requirement and says so.Clientin a checkout (Clients\,.waypoint-*) is named in the checkout's owninfo/exclude, so git does not list it and a switch of the checkout never stashes part of a client. Nothing tracked is changed.The Game client window is a chooser (0bf01de)
Two small fixes
PSModulePathat its start, as PowerShell 7 does when it starts Windows PowerShell itself.Texts and docs
New texts are short, plain sentences, in English, Russian and Simplified Chinese. Texts no longer used are out of the catalogs.
docs/launcher.mdand the README describe all of the above.How it was checked
dotnet build Waypoint.slnxandWaypoint.Linux.slnx: 0 warnings.dotnet test Waypoint.slnx: 464 passed.tests/Launcher.Checks: 208 passed.tests/*.Tests.ps1andtests/*.Tests.py: all pass.tools/missing-translations.py: clean.Not checked
--client-mode linkpath on a release; only the refusal for keys that do not fit was seen.For review
info/excludeis new. LocalExile's.gitignorecould name/Clients/and/.waypoint-*too, but a tracked file would not hold on an older revision, so the exclude stays needed either way.Clients\rather than deleted; "Delete this copy…" removes it.