Repository navigation
fix: extract only what the servers read on a split-database checkout - #29
Merged
Merged
Conversation
The -Servers check in SetupSequence.ExtractsForServers had a literal backspace (0x08) in its pattern where a \b word boundary was meant, so it never matched. Setup, and the Control section's -List, ran the whole 16-entry manifest instead of the two entries the servers read. A Launcher.Checks case now covers the check. The documented `dotnet publish src/Waypoint -o .` also failed on SDK 10.0.403: the output folder reaches Launcher.Core, and the SDK leaves files under it out of the sources, so nothing compiled (CS0246). The README, docs/launcher.md and Waypoint.csproj now publish to publish\, which is git-ignored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reverts the README, docs/launcher.md, Waypoint.csproj comment and .gitignore changes that moved `dotnet publish src/Waypoint -o .` to a publish\ folder. This pull request is only the -Servers check fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a checkout from after LocalExile's database split, setup's Extract the game data step (and the Control section's extract
-List) still ran the whole 16-entry manifest ofextract-data.ps1. The servers only need the two entries markedServers(client-constantsandgame-pack).The cause is in
SetupSequence.ExtractsForServers: its pattern\[switch\]\$Serversended in a literal backspace character (0x08) where the\bword boundary was meant. No script contains a backspace, so the check always returned false and Waypoint never passed-Servers. It was the only control character in the repository's sources.Changes
src/Launcher.Core/SetupGuide.cs: replace the backspace with\b.tests/Launcher.Checks/SetupChecks.cs: three new checks:-Serversis detectedServers…name, is notAn earlier commit here also changed the documented publish command; the second commit reverts it, so the docs are as on
main.Checks
dotnet build Waypoint.slnx: 0 warningsdotnet test Waypoint.slnx: 397 passedtests/Launcher.Checks: 200 passed, including the three new checkstools/missing-translations.py: nothing missing (no interface text changed)tests/*.Tests.ps1: 9 of 11 pass.ModControl("selected source builds use the real .NET build…") andModsfail in the same way without this change:scripts/and those tests are identical tomain. TheModsfailure is a 263-character temp path, over Windows PowerShell's 260-character limit.745838dd, whose script takes-Servers. The fixed check returns true on a copy of that script'sparamline. I haven't yet seen a setup run end to end with[1/2].🤖 Generated with Claude Code