Repository navigation
fix: add shield-based chaos damage to skeleton hits from Dead Reckoning - #836
Merged
2 commits merged intoNov 11, 2026
Merged
2 commits merged into
2 commits merged into
Conversation
This was referenced Nov 11, 2026
ac72119
Collaborator
|
Included in the batch #849 (not merged yet), at this PR's head 89ff518 on main a6e3b6a. Tested on the combined batch: solution build clean, Gateway 280/280 on three runs, Data 45/45, Core 435/436 (the one failure is the HNC mask test, which needs a 3.29.3c client and fails on main too), docs scan clean. Not checked in the live client. Thanks! This is the current Dead Reckoning: no Intelligence threshold, the shield's energy shield from local values, the off-hand only while it is active, scaled by added-damage effectiveness and applied before increases. Follow-ups:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Dead Reckoning modifier uses the equipped shield’s own energy shield. Skeleton attacks and damaging spells now receive that flat chaos contribution before their normal damage modifiers, with their skill's added-damage effectiveness. Changes to the jewel or shield feed the existing minion refresh. Other minion families do not receive it. The historical intelligence threshold for the old mage variant is separate from this current modifier.
The existing summon-runtime regression now equips a one-handed wand and shield, checks a living skeleton’s hit gains chaos when the jewel is socketed, removes the shield and verifies the original damage is restored. A native Witch carried a 28% roll and cast Summon Skeletons in the Coast. The combat damage comparison was made in the server test.
Base a6e3b6a, head 89ff518. Solution built; Gateway 244/244, Core 434/434, Data 45/45. Also integrated after #825, #826, #827, #828, #830 and #831 for the native session. Refs #355. Item reference: https://poedb.tw/us/Dead_Reckoning