Repository navigation
fix(gm-commands): relight the Righteous Fire that /god and /set_aoe saw - #45
Merged
evrydayjunglist merged 1 commit intoNov 18, 2026
Merged
Conversation
LocalExile's RelightRighteousFire now takes the Righteous Fire its caller saw before its own sends (LocalExile/LocalExile#1070). Both commands capture it under the combat lock with their own change. 1.4.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
GM Commands is the mod with the development and testing chat commands. This makes
/godand/set_aoework on LocalExilemainagain (version 1.4.1).LocalExile/LocalExile#1070 (merged, not yet in a release) gave
Game.RelightRighteousFirea requiredexpectedRelightparameter: the Righteous Fire the caller saw before its own sends, so the relight never attaches to one that started in between. Both commands called it without one, so onmain:CS7036atGmCommands.csandRules.Campaign.cs);MissingMethodExceptionfrom/godand/set_aoe, and the Gateway ended the connection.Both commands change the character's area of effect and then relight a burning Righteous Fire, with their own sends in between. Each now reads
conn.RighteousFireunderlock (conn.Monsters), in the same lock as its own change, and passes it to the relight.mod.jsongoes to 1.4.1 andmods.jsonis rebuilt withtools/build-index.ps1.compatibleClientVersionsis unchanged (0.5.2-beta, as 1.4.0 already lists): the reviewer sets the real release before merging.Requires LocalExile Update
The mod needs LocalExile/LocalExile#1070, which is merged into
mainand in no release yet (the latest release is v0.5.1-beta, where 1.3.0 is the working version).How it was tested in game
Built against LocalExile
main94b37d1ab(0 warnings, 0 errors), installed toMods/Binaries/gm-commands/, regular client throughscripts/dev/live.ps1:/mod:gm-commands 1.4.1 - feature, 2 hook(s)./god immune,/set_aoe 50,/set_aoe off,/god off: each answered as before and the connection stayed./mod_reload gm-commands, then/godand/god off: reloaded and answered; noan unloaded mod is still in memoryline and no exception in the Gateway log.Not tested: the relight itself with a Righteous Fire burning; the test character has none.