Skip to content

fix(gm-commands): relight the Righteous Fire that /god and /set_aoe saw - #45

Merged
evrydayjunglist merged 1 commit into
LocalExile:mainfrom
evrydayjunglist:fix/gm-commands-relight
Nov 18, 2026
Merged

evrydayjunglist merged 1 commit into
LocalExile:mainfrom
evrydayjunglist:fix/gm-commands-relight

Conversation

@evrydayjunglist

Copy link
Copy Markdown
Collaborator

What changes

GM Commands is the mod with the development and testing chat commands. This makes /god and /set_aoe work on LocalExile main again (version 1.4.1).

LocalExile/LocalExile#1070 (merged, not yet in a release) gave Game.RelightRighteousFire a required expectedRelight parameter: the Righteous Fire the caller saw before its own sends, so the relight never attaches to one that started in between. Both commands called it without one, so on main:

  • the mod's source no longer compiled (CS7036 at GmCommands.cs and Rules.Campaign.cs);
  • a build made before that change threw MissingMethodException from /god and /set_aoe, and the Gateway ended the connection.

Both commands change the character's area of effect and then relight a burning Righteous Fire, with their own sends in between. Each now reads conn.RighteousFire under lock (conn.Monsters), in the same lock as its own change, and passes it to the relight.

mod.json goes to 1.4.1 and mods.json is rebuilt with tools/build-index.ps1. compatibleClientVersions is unchanged (0.5.2-beta, as 1.4.0 already lists): the reviewer sets the real release before merging.

Requires LocalExile Update

The mod needs LocalExile/LocalExile#1070, which is merged into main and in no release yet (the latest release is v0.5.1-beta, where 1.3.0 is the working version).

How it was tested in game

Built against LocalExile main 94b37d1ab (0 warnings, 0 errors), installed to Mods/Binaries/gm-commands/, regular client through scripts/dev/live.ps1:

  • /mod: gm-commands 1.4.1 - feature, 2 hook(s).
  • /god immune, /set_aoe 50, /set_aoe off, /god off: each answered as before and the connection stayed.
  • /mod_reload gm-commands, then /god and /god off: reloaded and answered; no an unloaded mod is still in memory line and no exception in the Gateway log.

Not tested: the relight itself with a Righteous Fire burning; the test character has none.

LocalExile's RelightRighteousFire now takes the Righteous Fire its caller saw before its own sends (LocalExile/LocalExile#1070). Both commands capture it under the combat lock with their own change. 1.4.1.
@evrydayjunglist evrydayjunglist added the Requires LocalExile Update This mod will only be compatible after a certain LocalExile PR is merged to support this mod. label Nov 18, 2026
@evrydayjunglist
evrydayjunglist merged commit 91bf519 into LocalExile:main Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Requires LocalExile Update This mod will only be compatible after a certain LocalExile PR is merged to support this mod.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant