Skip to content

fix(gm-commands): refresh cached stash tabs after item_tab - #42

Merged
evrydayjunglist merged 1 commit into
LocalExile:mainfrom
nikolos89:codex/gm-commands-stash-refresh
Nov 18, 2026
Merged

evrydayjunglist merged 1 commit into
LocalExile:mainfrom
nikolos89:codex/gm-commands-stash-refresh

Conversation

@nikolos89

@nikolos89 nikolos89 commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

What changes

/item_tab now refreshes a slotted stash tab even when the server has unloaded its inventory but the client still displays its cached page.

Previously, filling persisted the added quantities, then sent an inventory change only when TabsSentOf still contained the target tab. A player could therefore receive a successful command reply while the visible quantities stayed unchanged. This was reproduced with /item_tab Делириум 200: the added items were present in the save while the client continued showing older counts.

The slotted-fill handler now uses the existing Game.SendTabChange helper whenever items change. It loads the target inventory and announces it first when needed, then publishes the normal inventory delta. The command performs the fill once; refreshing does not add items again.

  • Bump GM Commands from 1.4.0 to 1.4.1.
  • Describe the cached-tab refresh behavior in its README.
  • Regenerate mods.json with tools/build-index.ps1.
  • Retain the existing 0.5.2-beta compatibility requirement of GM Commands 1.4.0; the helper used by this correction already exists in LocalExile.

Why this is a mod change

GM development commands live in LocalExile-Mods. Normal game storage and special-slot stacking are covered by LocalExile #985; this notification correction needs no new server API.

Validation

  • Base: 3fea6830404e4bb0e58e3cfe176775c458402031
  • Head: 027e695481127e6a15ffa73e8fb934046671cd1d
  • The changed C# file matches the locally installed and successfully compiled source byte for byte; build completed with zero warnings and errors.
  • The running Gateway hot-loaded the corrected mod without restarting the server or client.
  • The existing Gateway stash-reload regression covers inventory loading before the change packet. The reported stale-view case was confirmed against both server logs and the saved quantities; no extra fill was performed after deploying this notification correction.
  • tools/build-index.ps1 -Check passes for all 11 indexed mods.
  • Diff/documentation scans are clean. Only this mod and its generated catalog entry are changed.

@evrydayjunglist
evrydayjunglist merged commit 00980ea into LocalExile:main Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants