fix(series): split the series 'in library' pill into owned vs missing#724
Draft
kevinheneveld wants to merge 1 commit into
Draft
fix(series): split the series 'in library' pill into owned vs missing#724kevinheneveld wants to merge 1 commit into
kevinheneveld wants to merge 1 commit into
Conversation
"In library" should mean you actually have the audio, not just a tracked record. A series page of monitored-but-fileless records counted them all as "N in library", implying ownership that isn't there. Split the pill: owned = has files; missing = tracked record with no files yet (these are the automatic-search targets); "ready to add" keeps its own pill. Note: the kevin/live original (02a3b2d) also made its edition-dedup work key position-aware — that machinery (buildWorkKey/seriesDisplay.ts) doesn't exist on canary, whose catalog dedup is ASIN/title+author based and never had the volume-collapse bug, so only the pill split applies. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On a series page, "N in library" counted every tracked record — including monitored-but-fileless ones — implying ownership that isn't there. Split the pill: owned (has files, success variant) vs missing (tracked record with no files yet — i.e. the automatic-search targets, warning variant); "ready to add" keeps its own pill (default variant).
Tests
Frontend-only;
vue-tsc+ eslint + prettier clean, full vitest suite passing.🤖 Generated with Claude Code