fix(toasts): keep warning/error toasts until dismissed#710
Draft
kevinheneveld wants to merge 1 commit into
Draft
fix(toasts): keep warning/error toasts until dismissed#710kevinheneveld wants to merge 1 commit into
kevinheneveld wants to merge 1 commit into
Conversation
Warning and error toasts auto-dismissed after 5s like info/success, but they carry information the user needs to read and act on (e.g. why an operation failed) and too often vanished before they could be read. Default warning/error toasts to timeoutMs = 0 (sticky); they're closed via the existing close button on each toast. info/success keep the 5s auto-dismiss, and callers can still pass an explicit timeout to opt warning/error back into it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Warning and error toasts auto-dismiss after 5s, the same as info/success. But they carry information the user needs to read and act on — e.g. why a file operation failed — and frequently vanish before they can be read, especially when several stack up.
Change
Default
warning/errortoasts totimeoutMs = 0(sticky). They're dismissed via the close button (×) already present on every toast.info/successkeep the 5s auto-dismiss, and callers can still pass an explicit timeout to opt warning/error back into auto-dismiss.push()already treats a0/falsy timeout as "no auto-dismiss", so no other change is needed.vue-tscpasses.🤖 Generated with Claude Code